Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library stats not displaying expecting wallpapers size #34

Closed
borisfaure opened this issue Apr 13, 2024 · 6 comments
Closed

Library stats not displaying expecting wallpapers size #34

borisfaure opened this issue Apr 13, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@borisfaure
Copy link

When running the Library stats function, it says I have 0 Fitting Wallpapers and lots of Excessive Wallpapers.
Insufficient Wallpapers are indeed correct.
It would be great to know what is the expected size to have Fitting Wallpapers.

@Hamza417
Copy link
Owner

Fitting Wallpapers simply means the wallpapers that are exactly the resolution of your device. I haven't found the proper term for that yet.

@borisfaure
Copy link
Author

When browsing the wallpapers, their size can be displayed and that's great to know.
I think my wallpapers are actually the fitting size, but since I can't see what the app expects, I don't know if I'm right

@Hamza417
Copy link
Owner

@borisfaure In the main list, insufficient wallpapers have a warning indicator, the excessive wallpapers are just to indicate the wasted details and space. I'll try to add better explanation for this in the app.

@borisfaure
Copy link
Author

Most of my wallpapers are 1080 x 2400 pixels, which is supposed to be the size of the display, but they're not considered as fitting, that's why I'd like to know what is the expected size for Peristyle.

@Hamza417
Copy link
Owner

I checked and there was a bug, the returned value doesn't include the status bar height in the height.

@Hamza417 Hamza417 added the bug Something isn't working label Apr 14, 2024
Hamza417 added a commit that referenced this issue Apr 14, 2024
@Hamza417
Copy link
Owner

It's fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants