Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update alert.lua: allow window object as parameter #3542

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Update alert.lua: allow window object as parameter #3542

merged 1 commit into from
Dec 10, 2023

Conversation

muescha
Copy link
Contributor

@muescha muescha commented Sep 30, 2023

allow also a hs.window object as an parameter

@muescha
Update alert.lua: allow window object as parameter
f3e51a2 
allow also a `hs.window` object as an parameter
github-actions[bot]
github-actions bot requested changes Sep 30, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['pr-fix', 'pr-change', 'pr-feature', 'pr-maintenance']

@muescha
Copy link
Contributor Author

muescha commented Sep 30, 2023

optional: it is possible to change it just to screenObj:frame() because both hs.window and hs.screen have the :frame() method:

local screenFrame = screenObj:frame()

@muescha
Copy link
Contributor Author

muescha commented Sep 30, 2023

  • should I rename the screenObj?
  • should also an hs.geometry parameter allowed?

@github-actions
Copy link

View Test Results

348 tests   296 ✔️  1h 2m 51s ⏱️
    2 suites    52 💤
    1 files        0 ❌

Results for commit f3e51a2.

@muescha muescha mentioned this pull request Sep 30, 2023
Closed
@muescha
Copy link
Contributor Author

muescha commented Oct 19, 2023

@cmsj

This pull request does not contain a valid label. Please add one of the following labels: ['pr-fix', 'pr-change', 'pr-feature', 'pr-maintenance']

@cmsj a user can not set the label - so I can not fix the requested changes

@cmsj cmsj added the pr-feature Pull Request implementing a feature label Dec 10, 2023
@cmsj cmsj merged commit 00aace7 into Hammerspoon:master Dec 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
pr-feature Pull Request implementing a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muescha @cmsj