Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Twig] Optimize Template collector #321

Closed
4 tasks done
Haehnchen opened this issue Jul 30, 2014 · 3 comments
Closed
4 tasks done

[Twig] Optimize Template collector #321

Haehnchen opened this issue Jul 30, 2014 · 3 comments

Comments

@Haehnchen
Copy link
Owner

Twig template files are in fileindex as virtualfiles. but currently there is a recursive path walking and later on a to psifile converting. as it was good in beginning times its now a performance issue in many cases.

  • check composer libs issues, files should be inside allScope
  • use allScope fileindex instance to get template files
  • only use psifile where needed
  • mass refactoring :(
Haehnchen added a commit that referenced this issue Aug 16, 2014
@Haehnchen
complete refactoring of template related stuff for massive performanc…
4803d3c 
…e and memory improvements; only use VirtualFile object and convert them later to PsiFile; also fixing cache of overwrite/implements twig linemarker #321
@Haehnchen
Copy link
Owner Author

"FileBasedIndex" are slower by factor 2-3

Haehnchen added a commit that referenced this issue Aug 16, 2014
@Haehnchen
also optimize template filename resolving #321
bb0b027
@ureimers
Copy link

I think for such a patience-needing task you deserve some applause (not ironical!).

So thanks for optimizing this!

@Haehnchen
Copy link
Owner Author

thx :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Haehnchen @ureimers