Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support manifest.json w/o Webpack Encore #2006

Closed
althaus opened this issue Aug 17, 2022 · 1 comment
Closed

Support manifest.json w/o Webpack Encore #2006

althaus opened this issue Aug 17, 2022 · 1 comment
Labels
fixed

Comments

@althaus
Copy link

althaus commented Aug 17, 2022

Hey,

in 3c4182e you've added support for reading assets from a manifest.json. The path is hardcoded to build/manifest.json in the web directory.

We're using Webpack without Encore and our build path has a different name. It'd be great if the plugin could either just glob for the manifest files or the path could configurable or multiple paths could be configured.

Cheers
Matthias
Haehnchen added a commit that referenced this issue Aug 18, 2022
@Haehnchen
#2006 Support manifest.json w/o Webpack Encore
a4b5fd8
@Haehnchen
Copy link
Owner

👍 every file named "manifest.json" independent from is path is now also taken

Haehnchen added a commit that referenced this issue Aug 18, 2022
@Haehnchen
#2006 Support manifest.json w/o Webpack Encore
25b6cf1
Haehnchen added a commit that referenced this issue Aug 18, 2022
@Haehnchen
Merge pull request #2007 from Haehnchen/feature/2006-manifest
ddb68fe 
 #2006 Support manifest.json w/o Webpack Encore
@althaus althaus closed this as completed Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@althaus @Haehnchen