Custom Twig file icons by its content

[Haehnchen]

Provide custom file icon, to indicate Twig templates types by this content:

• only blocks
• only macros
• extends as "page templates"?
• extends with attached controller?
• ...

We also now how a template is in used based on the usage index, via embed, include, ... maybe its also suitable hint.

[tomschwiha]

Is there an option available to disable this behavior?

[keichinger]

@Haehnchen is there an accessibility option to change colors? I'm red-green color blind and I can't properly distinguish anything that looks remotely as red or green (that includes orange, brown and any hues between).

Can I make a suggestion and maybe use different shapes instead of solely relying on colors? Git Tower had the same problems when they introduced the GPG signing status of a commit and they quickly changed it to colors + shapes after we've filed feedback due to the same reasons.

[Haehnchen]

@keichinger i was really thinking about this when picking a color, looks like i failed. ;)

All improvements are welcome, feel free to give some suggestions:

• suitable colors
• shape style

related icons:
https://github.com/Haehnchen/idea-php-symfony2-plugin/blob/master/src/main/resources/icons/twig_controller_file%402x.png
https://github.com/Haehnchen/idea-php-symfony2-plugin/blob/master/src/main/resources/icons/twig_extends_file%402x.png

[keichinger]

@Haehnchen no worries, your initial work is great stuff and for most parts, I can already work with it! ☺️
To be honest, it is a hard problem to solve, especially for someone that doesn't have these problems (sorry, if I made a wrong assumption!).

Personally, for me the twig_extends_file icon is totally fine. That gives me a bright and good contrast to the underlying green icon. Other people that have a different color deficiencies might think differently.

The twig_controller_file icon is getting harder to distinguish with Twig's green icon. Making it blue(ish) and/or give it a triangle shape, would help me personally. I'm probably the worst person when it comes to deciding which colors to pick, since colors look different to me than it does to you :( I'm not sure whether it might be best to either provide a preset of different icons for various color deficiencies, and/or make it configurable in PhpStorm itself.

What do you think?