Crash sound effect #841
Crash sound effect #841
Conversation
mountainflaw
requested review from
Reonu,
gheskett and
arthurtilly
as code owners
|
This is ready for review. |
| .envelope_critical_error: | ||
| envelope_line 1 32760 | ||
| envelope_line 128 0 | ||
| envelope_line 500 500 | ||
| envelope_goto 4 |
There was a problem hiding this comment.
This envelope is extremely scuffed. The 500 500 line is taking the sound from 0 and actually adding to it first off (so just remove that line). Secondly, that goto line is very bad news; please use a hang for that instead.
Also this should be moved to the bottom of the file, where envelopes go.
| @@ -6986,6 +6986,42 @@ sound_ref .sound_menu_power_meter | |||
| sound_ref .sound_menu_camera_buzz | |||
| sound_ref .sound_menu_camera_turn | |||
|
|
|||
| // Crash screen error sfx | |||
|
|
|||
| sound_ref .sound_menu_critical_error | |||
There was a problem hiding this comment.
This should not have any whitespace above it; I can see this very easily causing problems for people. (Just add that comment to the same sound_ref line.)
| .layer_critical_error_0: | ||
| layer_note1 3, 0x3f, 115 | ||
| layer_end | ||
|
|
||
| .layer_critical_error_1: | ||
| layer_note1 15, 0x3f, 115 | ||
| layer_end | ||
|
|
||
| .layer_critical_error_2: | ||
| layer_note1 34, 0x3f, 115 | ||
| layer_end | ||
|
|
||
| .layer_critical_error_3: | ||
| layer_note1 39, 0x3f, 115 | ||
| layer_end |
There was a problem hiding this comment.
Move these below the channel definition, for consistency with the rest of the file. Also given the jumpscare nature of this sound, I'd lower the velocities on these just a bit (like 103 maybe? Might need to see a video example or something that compares against the old sound in a proper gameplay context).
There was a problem hiding this comment.
It’s not that loud, and is especially less jumpscare than the current sound.
| @@ -555,6 +555,7 @@ enum SoundBank { | |||
| #define SOUND_MENU_HIGH_SCORE /* 0x70222081 */ SOUND_ARG_LOAD(SOUND_BANK_MENU, 0x22, 0x20, SOUND_DISCRETE) // unverified | |||
| #define SOUND_MENU_STAR_SOUND_OKEY_DOKEY /* 0x7023FF81 */ SOUND_ARG_LOAD(SOUND_BANK_MENU, 0x23, 0xFF, SOUND_DISCRETE) | |||
| #define SOUND_MENU_STAR_SOUND_LETS_A_GO /* 0x7024FF81 */ SOUND_ARG_LOAD(SOUND_BANK_MENU, 0x24, 0xFF, SOUND_DISCRETE) | |||
| #define SOUND_MENU_CRITICAL_ERROR SOUND_ARG_LOAD(SOUND_BANK_MENU, 0x40, 0xFF, SOUND_DISCRETE) | |||
There was a problem hiding this comment.
Add a comment with the hex for this, to be consistent with the other sounds.
There was a problem hiding this comment.
The hex in general within that file should be removed to be consistent with the repo. Those addresses don’t even line up with anything since they’re from decomp.
There was a problem hiding this comment.
Nevermind I realize it’s just a magic number not an address lmao
I'm tired of WOOOOOOOOOOOAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAOOOOOOOOOOOOOOOOOOOOOOOOOO everytime my game crashes.
This is meant to just be an okay-ish remake of the Windows XP error sound.