Various Title Screen Demo Enhancements #833
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 3, 2024 18:19
…at) from demos; made bowser 1 demo work again
someone2639
force-pushed
the
demo_upgrade
branch
from
cf78ed2 to
f437e5f
Compare
added 12 commits
September 4, 2024 09:41
|
Ready to review! Still have to test on console to see if my DMA's are valid but I did manage to record some new demos |
gheskett
added
enhancement
|
HMC does not crash on console (even after letting it play twice) and all the new demos work too 👍 |
someone2639
removed
the
needs console verification
|
This PR is ready for (re-)review. The Yaw/Mag based demo format has been dropped, but every button is now supported, so that developers can still record on their preferred camera system. |
added 8 commits
December 15, 2024 17:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally, a PR that nobody asked for!
Summary of changes:
DISABLE_DEMOis defined (0x800 byte memory savings)camera-agnosticformat. Vanilla demos have been converted to this formatand are no longer broken.Demo files have been removed fromassets.jsondemo_system.cand.h, and moved demo related functions and variables to that file (Currently 233 lines of stuff that doesn't need to be in a hack without demos).DEMO_RECORDING_MODE, which boots straight toSTART_LEVELand prints the new demo format to the debug console.tools/demo_data_converter.pyhas been rewritten to detect demos in the assets folder, and the hardcodedassets/demo_data.jsonhas been deleted.DISABLE_DEMOis commented out but no demos are present.