-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use libdragon compression scheme #817
base: develop/2.4.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replacing LOAD_YAY0
with LOAD_YAZ0
only serves to introduce merge conflicts and break fast64 compatibility. If we're replacing yay0, then changing the level script command doesn't matter other than to not be misleading (which is already the case with MIO0; maybe add a comment explaining the reality to the macro definitions or something idk).
or fix fast64? |
Not worth it tbh; that's its own logistical headache even with a HackerSM64 checkbox (that still isn't implemented). |
how is it a logistical headache when you can make it equivalent to the current macro? |
By being incompatible with HackerSM64 2.3; this alone means destroying HackerSM64 backwards compatibility (on fast64's end). |
Don't most people auto update fast64? |
No probably, but that doesn't matter; HackerSM64 is not the source of truth for exporting defaults, nor should it attempt to be wherever possible |
Regardless, adding level script merge conflicts here would also put this PR well outside of 2.4 scope |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait nevermind, the segment names all have yaz0 suffixes. Double reject.
I undid all of the renames. |
As per usual with my pull requests, this will be experiencing some scope creep. I've decided it's probably best to just ditch the current compression options entirely, and replace them with their libdragon equivalents rather than just add aPLib and YAZ0. I plan to actually ditch YAZ0 and move forward with importing LZ4 as its replacement, and replace deflate with shrinkler. By the end, we should just have |
Uses devwizard's assembly decompressor and Wiseguy's compressor tool. This would replace yay0 with yaz0 with zero downsides.