Fix cake screen crashing the game when not warping from area 1 #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So while this is a valid solution to the cake screen crash, I'm personally not a fan of this approach. It is valid to have a level script that has a camera but doesn't spawn Mario, and this solution doesn't cover those cases. The better thing would probably be to set the area to NULL or something when it's unloaded and throw it behind a NULL check. This is a higher-risk approach however, so further research and playtesting may be warranted. |
gheskett
added
the
questionable
|
This PR is now redundant in favor of #844. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The funny crash is gone