-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Walk Speed Input Polling #765
Open
YoshiMilkman
wants to merge
9
commits into
HackerN64:develop/2.4.0
Choose a base branch
from
YoshiMilkman:walk_polling_fix
base: develop/2.4.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f607654
Added a define to fix walk speed polling causing inconsistent acceler…
YoshiMilkman 3cb8cbd
Made this not a define
YoshiMilkman 209998a
Clean up config_movement.h
YoshiMilkman a3b6e74
Use actionarg for proper polling fix
YoshiMilkman d035293
Use dedicated u8 for detecting first frame instead of m->actionArg
YoshiMilkman 0cfb47a
Go back to using m->actionArg lol
YoshiMilkman 54be705
Make boost smaller when holding an object to matchvanilla acceleratio…
YoshiMilkman c3641ce
Make boost smaller when holding an object to matchvanilla acceleratio…
YoshiMilkman 637185a
Remove funny blank space
YoshiMilkman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably makes more sense to use
actionTimer
for this instead ofactionArg
.actionTimer
would need to be incremented somewhere (probably this function) rather than hardset to 1, and would need a conditional to cap it.This is still a movement change so I'm hesitant to merge this without some sort of define for this, even if it's ultimately not inside a config file. Seems like this isn't even useful for framewalking thanks to the steep slope check, so idk how much benefit this offers anyway (Kaze seems to think it's noticeable though).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WE ARE NOT MAKING THIS A DEFINE!!!!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I did say it'd need to be housed outside of the config file...