-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add F3DEX3 Microcode Option and Support #764
Conversation
Feedback addressed. |
good enough, added to my repo. |
This should be ready to merge! :) |
merge this pr please |
Please do not merge until CameraWorld logic is fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really dislike that .o files are posted in repo instead of doing similar approach to other microcodes. When F3DEX3 is built, we get data .code and .data files. Let's use them instead. A sample can be seen here aglab2/RoyalLegacy@a6c6e43
Regarding backwards compatibility and RSP hang crash, it will never be resolved unless HLE plugins support new G_RELSEGMENT instruction https://github.com/HackerN64/F3DEX3/blob/main/gbi.h#L2616-L2619 . If this instruction is not supported, segments are not set causing aforementioned crash. Moreover even if that instruction is supported, lights loading is changed hence visuals will look weird. My opinion is that if dev wants to use F3DEX3, they have to accept that Jabo will break. |
jabo sucks, so it's fine |
Succeeded by #816 . |
Version shipped is from 7b06c8117dc1748f7a1a855092c5dfa5109b55c5 on Fast3DEX3 master (HackerN64/F3DEX3@7b06c81).
Also fixes lighting direction and adds support for CameraWorld (required for fresnel and specular lighting).