Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add F3DEX3 Microcode Option and Support #764

Closed
wants to merge 30 commits into from

Conversation

mountainflaw
Copy link
Contributor

Version shipped is from 7b06c8117dc1748f7a1a855092c5dfa5109b55c5 on Fast3DEX3 master (HackerN64/F3DEX3@7b06c81).

Also fixes lighting direction and adds support for CameraWorld (required for fresnel and specular lighting).

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
src/game/rendering_graph_node.c Show resolved Hide resolved
src/game/rendering_graph_node.c Show resolved Hide resolved
@gheskett gheskett changed the base branch from master to develop/2.2.0 February 5, 2024 00:22
@gheskett gheskett added enhancement New feature or request monkaS monkaS labels Feb 5, 2024
@gheskett gheskett added the performance Issue or feature related to game performance label Feb 5, 2024
@gheskett gheskett added this to the 2.2 milestone Feb 5, 2024
@gheskett gheskett added the critical Extremely important issue or feature / highest priority label Feb 5, 2024
@arthurtilly arthurtilly removed the critical Extremely important issue or feature / highest priority label Feb 5, 2024
@mountainflaw
Copy link
Contributor Author

Feedback addressed.

README.md Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@SonicTheHedgeHog64
Copy link

good enough, added to my repo.

@mountainflaw
Copy link
Contributor Author

This should be ready to merge! :)

@SonicTheHedgeHog64
Copy link

merge this pr please

gheskett
gheskett previously approved these changes Feb 14, 2024
@mountainflaw
Copy link
Contributor Author

Please do not merge until CameraWorld logic is fixed.

@gheskett gheskett added the do not merge Do not merge (yet) label Feb 19, 2024
@gheskett gheskett dismissed their stale review February 19, 2024 00:34

Waiting on bugfix

@gheskett gheskett modified the milestones: 2.2, 2.3 Mar 2, 2024
@gheskett gheskett changed the base branch from develop/2.2.0 to develop/2.3.0 March 2, 2024 13:43
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really dislike that .o files are posted in repo instead of doing similar approach to other microcodes. When F3DEX3 is built, we get data .code and .data files. Let's use them instead. A sample can be seen here aglab2/RoyalLegacy@a6c6e43

@aglab2
Copy link
Collaborator

aglab2 commented Jun 1, 2024

Regarding backwards compatibility and RSP hang crash, it will never be resolved unless HLE plugins support new G_RELSEGMENT instruction https://github.com/HackerN64/F3DEX3/blob/main/gbi.h#L2616-L2619 . If this instruction is not supported, segments are not set causing aforementioned crash. Moreover even if that instruction is supported, lights loading is changed hence visuals will look weird. My opinion is that if dev wants to use F3DEX3, they have to accept that Jabo will break.

@SonicTheHedgeHog64
Copy link

Regarding backwards compatibility and RSP hang crash, it will never be resolved unless HLE plugins support new G_RELSEGMENT instruction https://github.com/HackerN64/F3DEX3/blob/main/gbi.h#L2616-L2619 . If this instruction is not supported, segments are not set causing aforementioned crash. Moreover even if that instruction is supported, lights loading is changed hence visuals will look weird. My opinion is that if dev wants to use F3DEX3, they have to accept that Jabo will break.

jabo sucks, so it's fine

@mountainflaw
Copy link
Contributor Author

Succeeded by #816 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Do not merge (yet) enhancement New feature or request monkaS monkaS performance Issue or feature related to game performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants