Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to file select menu #650

Open
wants to merge 2 commits into
base: develop/3.0.0
Choose a base branch
from

Conversation

ashifolfi
Copy link

  • Save file, save info, and lower button positions are now in arrays
  • Main menu button positions are now determined by submenu positions (multiplication)
  • copy menu button duplication bug fixed (typo in load_menu_from_submenu)
  • status message storage glitch fixed (sStatusMessageID is reset on submenu change)
  • all file info print instances are replaced with a call to a function to print
  • modified sCursorClickingTimer to count down instead of up

These changes make the file select menu less painful to modify for those wanting to adjust the layout while still providing a nearly if not identical menu for those who aren't looking to modify the file select menu.

Any additional edits or improvements are welcomed and encouraged.

- Save file, save info, and lower button positions are now in arrays
- Main menu button positions are now determined by submenu positions (multiplication)
- copy menu button duplication bug fixed (typo in `load_menu_from_submenu`)
- status message storage glitch fixed (`sStatusMessageID` is reset on submenu change)
- all file info print instances are replaced with a call to a function to print
- modified `sCursorClickingTimer` to count down instead of up
@ashifolfi ashifolfi requested a review from gheskett as a code owner June 29, 2023 16:51
@thecozies thecozies added documentation Improvements or additions to documentation needs verification Needs to be tested to ensure functionality subjective Multiple opinions are desirable labels Jun 29, 2023
@gheskett gheskett added this to the 3.0 milestone Jul 25, 2023
@gheskett gheskett modified the milestones: 3.0, 2.2 Sep 27, 2023
@gheskett gheskett changed the base branch from master to develop/2.2.0 September 27, 2023 01:40
@gheskett gheskett modified the milestones: 2.2, 3.0 Sep 27, 2023
@gheskett gheskett changed the base branch from develop/2.2.0 to develop/3.0.0 September 27, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation needs verification Needs to be tested to ensure functionality subjective Multiple opinions are desirable
Projects
Status: Needs Review
Development

Successfully merging this pull request may close these issues.

3 participants