-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add painting objects + convert vanilla paintings into objects #445
Open
Arceveti
wants to merge
114
commits into
develop/3.0.0
Choose a base branch
from
develop/2.1.0-painting-objects
base: develop/3.0.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poggggg |
Reonu
reviewed
Jul 6, 2022
arthurtilly
reviewed
Jul 19, 2022
arthurtilly
requested changes
Jul 19, 2022
…nto develop/2.1.0-painting-objects
…nto develop/2.1.0-painting-objects
…PAINTING_SIZE for vertex dls
…nto develop/2.1.0-painting-objects
…nto develop/2.1.0-painting-objects
…nto develop/2.1.0-painting-objects
…nto develop/2.1.0-painting-objects
…nto develop/2.1.0-painting-objects
…elop/2.1.0-painting-objects
…elop/2.1.0-painting-objects
…nto develop/2.1.0-painting-objects
…elop/2.1.0-painting-objects
…nto develop/2.1.0-painting-objects
…nto develop/2.1.0-painting-objects
don't let this die :( |
…nto develop/2.1.0-painting-objects
Repointing to 3.0 since this revolves around ASCII and seg2 cleanup (DO NOT PULL IN LATEST 2.4 TO THIS BRANCH PLEASE!!!) |
Any progress on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes paintings into objects. Vanilla paintings were previously a set of geolayout commands in the level geo, plus 6 specific floor types per painting.
Benefits of paintings being objects (and other painting improvements part of this PR):
To create a custom painting:
See vanilla paintings (castle_inside, hmc, ttm) for examples (paintings.inc.c, script.c).
TODO before merge: