Add VERTICAL_ROOMS define #430
Open
+16
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reonu
added
enhancement
thecozies
requested changes
Jul 22, 2022
| #ifdef ENABLE_VANILLA_LEVEL_SPECIFIC_CHECKS | ||
| if (gCurrLevelNum == LEVEL_BBH) { | ||
| // In BBH, check for a floor manually, since there is an intangible floor. In custom hacks this can be removed. | ||
| #ifdef VERTICAL_ROOMS |
There was a problem hiding this comment.
is there any issue with checking if gCurrentArea->surfaceRooms != NULL instead of using this define? i feel like there has to be a way if checking that an area has rooms before doing this check, that way we dont need to have a define for this and its automatic
There was a problem hiding this comment.
good point, I'll see if that works and if so I'll remove the define
There was a problem hiding this comment.
another consideration we're having: add a flag whether or not an area has surface intangible floors, then if flag then check
|
also bumping this one to get status |
|
I will fix this I promise |
|
He will apparently fix this, he promises. Someone kill him |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for vertical rooms
VERTICAL ROOMSis enabled,geo_switch_areawill do a manual floor check every frame to check for intangible floors.VERTICAL_ROOMSis disabled:ENABLE_VANILLA_LEVEL_SPECIFIC_CHECKSis enabled, do a manual floor check ONLY in BBH (this vanilla level is the only that uses vertical cloors)ENABLE_VANILLA_LEVEL_SPECIFIC_CHECKSis disabled, never do a manual floor check.