Skip to content
This repository has been archived by the owner on Jun 11, 2023. It is now read-only.

Make notifications clickable #497

Closed

Conversation

PedroHLC
Copy link
Contributor

@PedroHLC PedroHLC commented Mar 29, 2018

I love lasagna!


This change is Reviewable

@chrisfls
Copy link
Contributor

Reviewed 28 of 28 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


src/Game/Account/Notifications/OnClick.elm, line 14 at r1 (raw file):

        NewEmail _ ->
            config.openThunderbird

Clicking on it already marks it as read, right?


src/OS/Header/Config.elm, line 64 at r1 (raw file):

        config.onNewApp DBAdmin Nothing Nothing config.activeGatewayCId
    , openExplorerInFile =
        -- TODO: Explorer params

🤖 TODO FOUND


src/OS/Header/NotificationsView.elm, line 21 at r1 (raw file):
Kek, actioner is a valid word for this context?

From some dictionary online:

a film that features action, often extreme or violent; thriller


src/OS/Toasts/Config.elm, line 37 at r1 (raw file):

        config.onNewApp DBAdmin Nothing Nothing config.activeGatewayCId
    , openExplorerInFile =
        -- TODO: Explorer params

🤖 ANOTHER TODO


Comments from Reviewable

@chrisfls
Copy link
Contributor

chrisfls commented Apr 2, 2018

Review status: all files reviewed at latest revision, 1 unresolved discussion.


src/OS/Header/NotificationsView.elm, line 21 at r1 (raw file):

Previously, kress95 (Christian Ferraz Lemos de Sousa) wrote…

Kek, actioner is a valid word for this context?

From some dictionary online:

a film that features action, often extreme or violent; thriller

Change the name to "ToMsg" if you can't find anything better.


Comments from Reviewable

@PedroHLC
Copy link
Contributor Author

PedroHLC commented Apr 6, 2018

Review status: 27 of 28 files reviewed at latest revision, 1 unresolved discussion.


src/Game/Account/Notifications/OnClick.elm, line 14 at r1 (raw file):

Previously, kress95 (Christian Ferraz Lemos de Sousa) wrote…

Clicking on it already marks it as read, right?

There is no individual reading anymore!


src/OS/Header/Config.elm, line 64 at r1 (raw file):

Previously, kress95 (Christian Ferraz Lemos de Sousa) wrote…

🤖 TODO FOUND

Issue added


src/OS/Header/NotificationsView.elm, line 21 at r1 (raw file):

Previously, kress95 (Christian Ferraz Lemos de Sousa) wrote…

Change the name to "ToMsg" if you can't find anything better.

Done.


src/OS/Toasts/Config.elm, line 37 at r1 (raw file):

Previously, kress95 (Christian Ferraz Lemos de Sousa) wrote…

🤖 ANOTHER TODO

Issue added #500


Comments from Reviewable

@PedroHLC PedroHLC mentioned this pull request Apr 11, 2018
@PedroHLC
Copy link
Contributor Author

I'll squash this one into #501, so we have less work to merge it later...

@PedroHLC PedroHLC closed this Apr 19, 2018
@PedroHLC PedroHLC deleted the notifications-clickable branch April 19, 2018 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants