Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document #4420: 📝 Update the behavior of Home Key and End Key in the README file #4438

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Document #4420: 📝 Update the behavior of Home Key and End Key in the README file #4438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,8 @@ The examples are hosted within the docs folder and are ran in the simple app tha
- _Down_: Move to the next week.
- _PgUp_: Move to the previous month.
- _PgDn_: Move to the next month.
- _Home_: Move to the previous year.
- _End_: Move to the next year.
- _Home_: Move to the first day (e.g Sunday) of the current week.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this show in any user coach marks or UI elements as well as the readme? I assume the Readme is lagging behind the actual code fix for the behavior of the keypress.

◽ Clarify Intent

Image of John G John G

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi John,

Yes, I updated the Keyboard accessibility of the Home Key and the End Key to make it aligned with ARIA authoring practices guide and my PR already got merged to the main branch. I just noticed that I forgot to make an update in the README.md file regarding this change. Hence I created this patch PR to update the readme file.

This is the actual PR where I made the change - #4430 (review)

Only the Readme file is lagging behind the actual fix I made.

- _End_: Move to the last day (e.g. Saturday) of the current week.
- _Enter/Esc/Tab_: close the calendar. (Enter & Esc calls preventDefault)

#### For month picker
Expand Down
Loading