Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleaning boilerplate #212

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

cleaning boilerplate #212

wants to merge 7 commits into from

Conversation

saloumeh-67
Copy link
Contributor

@saloumeh-67 saloumeh-67 commented Mar 2, 2022 •
edited
Loading

Description

I removed

Frontend

src/client/containers/Home/
src/client/components/Sample/
src/client/containers/Profile/
src/client/containers/SignIn/
src/client/containers/SignUp/
src/client/containers/ResetPassword/

Backend

src/server/api/controllers/modules.controller.js
src/server/api/routes/modules.router.js

Databases

src/server/migrations/20200510015322_create_modules_schema.js

Fixes # (208)

##How to test?

git pull origin develop

Checklist

  • I have performed a self-review of my own code
  • I have followed the name conventions for CSS Classnames and filenames, Components names and filenames, Style filenames, if you are in doubt check the the project README.MD and here https://github.com/HackYourFuture-CPH/curriculum/blob/master/review/review-checklist.md
  • I have commented my code, particularly in hard-to-understand areas, if you code was simple enough mark the box anyway
  • I have made corresponding changes to the documentation, if you code was simple enough mark the box anyway
  • This PR is ready to be merged and not breaking any other functionality

@saloumeh-67 saloumeh-67 self-assigned this Mar 2, 2022
@dpfernandes dpfernandes linked an issue Mar 3, 2022 that may be closed by this pull request
Full stack: Remove code examples from the Boilerplate #208
Open
Divyajg
Divyajg reviewed Mar 3, 2022
View reviewed changes
Copy link
Contributor

@Divyajg Divyajg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems everything is cleaned, except src\server\seeds\development\modules.js and we are using Profile.container in our PR

FlorentinaPetica
FlorentinaPetica reviewed Mar 3, 2022
View reviewed changes
Copy link
Contributor

@FlorentinaPetica FlorentinaPetica left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a problem when I run dev ... it toggle between /sign-up and /profile

FlorentinaPetica
FlorentinaPetica reviewed Mar 3, 2022
View reviewed changes
src/client/App.js Outdated
@@ -2,11 +2,10 @@ import React from 'react';
import { BrowserRouter as Router, Route, Switch } from 'react-router-dom';
import { useAuthentication } from './hooks/useAuthentication';
import LandingPage from './containers/LandingPage/LandingPage.container';
import SignIn from './containers/SignIn';
import SignUp from './containers/SignUp';
import CreateAccountPage from './containers/CreateAccountPage';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add the right path for me it doesn't compile you need to add something like this: import CreateAccountPage from './containers/CreateAccountPage/CreateAccountPage.Container';

src/client/App.js Outdated
import ResetPassword from './containers/ResetPassword';
import AuthenticatedRoute from './components/Auth/AuthenticatedRoute';
import Profile from './containers/Profile';
import UserProfilePage from './containers/UserProfilePage';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here it doesn't compile use :
import UserProfilePage from './containers/UserProfilePage/UserProfilePage.Container';

FlorentinaPetica
FlorentinaPetica reviewed Mar 3, 2022
View reviewed changes
src/client/App.js Outdated
@@ -53,15 +52,14 @@ function App() {
</Route>

{/* Anonymous pages */}
<SignIn exact path="/sign-in" />
<SignUp exact path="/sign-up" />
<CreateAccountPage exact path="/sign-up" />
<ResetPassword exact path="/reset-password" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you deleted the container for ResetPassword you need to remove this line also.

src/client/App.js Outdated
@@ -2,11 +2,10 @@ import React from 'react';
import { BrowserRouter as Router, Route, Switch } from 'react-router-dom';
import { useAuthentication } from './hooks/useAuthentication';
import LandingPage from './containers/LandingPage/LandingPage.container';
import SignIn from './containers/SignIn';
import SignUp from './containers/SignUp';
import CreateAccountPage from './containers/CreateAccountPage';
import ResetPassword from './containers/ResetPassword';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you deleted the container for ResetPassword you need to remove this line.

FlorentinaPetica
FlorentinaPetica reviewed Mar 3, 2022
View reviewed changes
Copy link
Contributor

@FlorentinaPetica FlorentinaPetica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because you removed module.router and module.controler you need to remove from api-router.js the corresponding lines. Because the db is crashing ....

@Impressiv3
Copy link
Contributor

Impressiv3 commented Mar 6, 2022 •
edited
Loading

Is it just on my PC or the file names that we already have fixed a month ago are back to starting with capital letters again?
What I mean by that:
LandingPage.container
CreateAccountPage.Container
ForgotPasswordPage.container
OrderConfirmationPage.Container

image

@Impressiv3
Copy link
Contributor

There is a duplicate of LoginPage container here :)
image

@zkwsk zkwsk added the Low label Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpfernandes dpfernandes Awaiting requested review from dpfernandes

@Impressiv3 Impressiv3 Awaiting requested review from Impressiv3

@FlorentinaPetica FlorentinaPetica Awaiting requested review from FlorentinaPetica

@Divyajg Divyajg Awaiting requested review from Divyajg

@suvarna-ratna suvarna-ratna Awaiting requested review from suvarna-ratna

Assignees

@saloumeh-67 saloumeh-67

Labels
Backend Databases Frontend Low
Projects
None yet
Milestone
Milestone 2 - API & DB (Shopping Cart...
Development

Successfully merging this pull request may close these issues.

Full stack: Remove code examples from the Boilerplate
5 participants
@saloumeh-67 @Impressiv3 @FlorentinaPetica @Divyajg @zkwsk