#15230 Add positive integration scenario. #15232
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to lack of positive integration tests in repository I decided to add one for "/bug-report" endpoint.
On CI/CD there was one test failing due to my mistake with comparing object properties. I was mentioned hasOwnProperties, but I've tried wrongly to simplify to if statement.
Following eslint issues and commit about `.editorcofig` from AccioBooks <[email protected]> on 8/31/2016 at 7:44 PM I decided to fix all wrongly encoded new lines. Based on article https://www.aleksandrhovhannisyan.com/blog/crlf-vs-lf-normalizing-line-endings-in-git/ it should help in long term to keep new line issues in the future.
|
@SabreCat it seems to be ready to be reviewed 😄 |
negue
reviewed
Jun 14, 2024
| @@ -99,7 +99,13 @@ function _parseRes (res) { | |||
| message: res.body.message, | |||
| }; | |||
| } | |||
| return res.body.data; | |||
| if (Object.prototype.hasOwnProperty.call(res.body, 'data')) { | |||
There was a problem hiding this comment.
Could you tell me why this change is needed? this doesn't seem to be needed for the test above or I'm missing something 😬
There was a problem hiding this comment.
Because there are almost no of positive testing in repository. I had to modify requester logic.
if (res.body.message) {
return {
data: res.body.data,
message: res.body.message,
};
}
So far it was returning only if message was included.
For this test I basically need whole response if there is any. So that's why I need to expand this class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to lack of positive integration tests in repository I decided to add one for "/bug-report" endpoint.
Fixes put_#_and_issue_number_here
Changes
UUID: