Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor http client, fixes threads shut down not properly #392

Merged
merged 2 commits into from
Oct 11, 2022

Conversation

lostsnow
Copy link
Member

@lostsnow lostsnow commented Oct 11, 2022

java.net.URLConnection causes threads to fail to shut down properly when uninstalling the agent

@lostsnow lostsnow changed the title refactor http client, fixes java.net.URLConnection cause threads shut… refactor http client, fixes threads down not properly Oct 11, 2022
@lostsnow lostsnow changed the title refactor http client, fixes threads down not properly refactor http client, fixes threads shut down not properly Oct 11, 2022
TrustManager[] trustAllCerts = new TrustManager[]{new IastTrustManager()};
try {
SSLContext sc = SSLContext.getInstance(SSL_SIGNATURE);
sc.init(null, trustAllCerts, new java.security.SecureRandom());

Check failure

Code scanning / CodeQL

`TrustManager` that accepts all certificates

This [TrustManager](1), which is defined [here](2) and trusts any certificate, is used here.
@lostsnow lostsnow merged commit 158a2c4 into HXSecurity:main Oct 11, 2022
@lostsnow lostsnow deleted the feature/refactor-http-client branch October 14, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant