Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote control fixes #1337

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Remote control fixes #1337

merged 3 commits into from
Jul 19, 2024

Conversation

rmburg
Copy link
Contributor

@rmburg rmburg commented Jul 18, 2024

Why? What?

  • fix crash that occurred when receiving a shared autonomy challenge game controller message
  • add head joint control to remote panel

ToDo / Known Issues

it's perfect

How to Test

twix, remote control panel

@rmburg rmburg added tools:Debug Tooling Related to twix et.al. is:Bugfix labels Jul 18, 2024
@rmburg rmburg force-pushed the remote-control-fixes branch from 713b4f3 to 8dc4a05 Compare July 19, 2024 06:12
@rmburg rmburg enabled auto-merge July 19, 2024 10:26
@rmburg rmburg force-pushed the remote-control-fixes branch from 8dc4a05 to ab3b845 Compare July 19, 2024 10:45
@rmburg rmburg mentioned this pull request Jul 19, 2024
@rmburg rmburg force-pushed the remote-control-fixes branch from d561b59 to 9545253 Compare July 19, 2024 17:13
@schluis schluis self-assigned this Jul 19, 2024
Copy link
Contributor

@schluis schluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like

crates/control/src/motion/head_motion.rs Show resolved Hide resolved
@rmburg rmburg added this pull request to the merge queue Jul 19, 2024
Merged via the queue into HULKs:main with commit 901ecbc Jul 19, 2024
25 checks passed
@rmburg rmburg deleted the remote-control-fixes branch July 19, 2024 18:30
oleflb pushed a commit that referenced this pull request Sep 30, 2024
* Fix crash on game controller message in shared autonomy challenge

* Add injected head joints

* Reset head angle when disabling remote panel
pejotejo pushed a commit to pejotejo/hulk that referenced this pull request Nov 6, 2024
* Fix crash on game controller message in shared autonomy challenge

* Add injected head joints

* Reset head angle when disabling remote panel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:Bugfix tools:Debug Tooling Related to twix et.al.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants