Translation of Caching chapter to Japanese #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunetheweb
approved these changes
Feb 22, 2020
There was a problem hiding this comment.
Looks mostly good @ksakae1216 . Just a few questions on whether some terms should be translated or not. Feel free to ignore if you think it's fine as is.
|
@MSakamaki did you get a chance to review this yet? It's good to merge from my side but would be better if we can get a Japanese speaker to review first if possible. |
|
@MSakamaki Hi, Do you possible to review? |
|
@ksakae1216 @bazzadp |
MSakamaki
reviewed
Mar 9, 2020
There was a problem hiding this comment.
@ksakae1216
There are I commented on mistakes and term readability.
|
We good to merge this now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes progress on #586