Translation of Http2 chapter to Japanese #661
Conversation
There was a problem hiding this comment.
Thanks @ksakae1216 !
I've a few comments some due to changes I added recently (maybe do a merge with master into your branch to see these more easily in your branch?), and some about potentially missed translations (please feel free to ignore these if you feel it is not valid to translate them).
src/content/en/2019/http2.md
SDPY on line 334 is a typo.
The correct answer is SPDY.
Thanks, good spot! Fixed now in #662. Feel free to include corrections to the English chapters in your translation PRs in future if you spot things that look wrong. All corrections welcome! 😀
|
@ksakae1216 you also appear to have put this chapter in the wrong folder (src/content/ja/http2.md instead of src/content/ja/2019/http2.md). |
|
Hey @ksakae1216 thanks for that. However, I still see a few fixes missing from my review, so added comments on those again. BTW feel free to mark review items as "resolved" once you've done them. Makes it easier for you to track what's been done and what hasn't. I've not reviewed @MSakamaki 's suggestions as I don't understand the Japanese 😊, however I do still see three instances of "HTTP / 2" in your translation (which should be "HTTP/2" without spaces) on lines 60, 73 and 145. |
| [Patrick Meenan](https://twitter.com/patmeenan)は、優先度の高いオンスクリーンイメージを要求する前に、優先度の低いオフスクリーンイメージのロードを意図的にダウンロードしようとする[サンプルテストページ](https://github.com/pmeenan/http2priorities/tree/master/stand-alone)を作成しました。優れたHTTP/2サーバーはこれを認識し、優先度の低い画像を犠牲にして、要求後すぐに優先度の高い画像を送信できるはずです。貧弱なHTTP/2サーバーはリクエストの順番で応答し、優先順位のシグナルを無視します。 [Andy Davies](./contributors#andydavies)には、[Patrickのテスト用にさまざまなCDNのステータスを追跡するページ](https://github.com/andydavies/http2-prioritization-issues)があります。 HTTPアーカイブは、クロールの一部としてCDNが使用されるタイミングを識別しこれら2つのデータセットをマージすると、合格または失敗したCDNを使用しているページの割合を知ることができます。 | ||
|
|
||
| <figure markdown> | ||
| | CDN | 正しい優先順位付け? | デスクトップ | モバイル | 合計 | |
There was a problem hiding this comment.
Last one from my side @ksakae1216
- should CDN be translated?
- should “Not using CDN” be translated?
- should the status for each CDN (“Unknown”, “Pass” and “Fail”) be translated?
There was a problem hiding this comment.
Yes, I think that CDN (“Unknown”, “Pass” and “Fail”) don't translate.
Because I think Japanese people can understand without translating these words.
There was a problem hiding this comment.
Seems odd to me - do you agree @MSakamaki ? If so then I’m happy and good to merge this if you are.
Makes progress on #586
Please, review.
@bazzadp
src/content/en/2019/http2.md
SDPY on line 334 is a typo.
The correct answer is SPDY.