Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review of Japanese Performance chapter #610

Merged
merged 1 commit into from
Dec 31, 2019
Merged

Review of Japanese Performance chapter #610

merged 1 commit into from
Dec 31, 2019

Conversation

ksakae1216
Copy link
Contributor

@ksakae1216 ksakae1216 commented Dec 30, 2019 •
edited by tunetheweb
Loading

I reviewed, Plz confirm.

Part of #586

@ksakae1216 ksakae1216 requested a review from MSakamaki December 30, 2019 08:34
@tunetheweb tunetheweb added the translation world wide web label Dec 30, 2019
@tunetheweb tunetheweb changed the title review translate japanese Review of Japanese Performance chapter Dec 30, 2019
tunetheweb
tunetheweb approved these changes Dec 30, 2019
View reviewed changes
Copy link
Member

@tunetheweb tunetheweb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a technical point of view. @MSakamaki can you confirm you're happy and then we'll merge.

MSakamaki
MSakamaki approved these changes Dec 31, 2019
View reviewed changes
Copy link
Contributor

@MSakamaki MSakamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I admit!
It is okay to merge them.

@tunetheweb tunetheweb merged commit a9c964d into master Dec 31, 2019
@tunetheweb tunetheweb deleted the japanese-check-performance branch December 31, 2019 07:16
@tunetheweb
Copy link
Member

Thanks both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tunetheweb tunetheweb tunetheweb approved these changes

@MSakamaki MSakamaki MSakamaki approved these changes

Assignees
No one assigned
Labels
translation world wide web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ksakae1216 @tunetheweb @MSakamaki