-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect "total" numbers in Security chapter (2024, 2022, ?) #3912
base: main
Are you sure you want to change the base?
Conversation
I went through all the queries and it seems like only I uploaded the new data for the two fixed queries on the Google Sheets. https://docs.google.com/spreadsheets/d/1b9IEGbfQjKCEaTBmcv_zyCyWEsq35StCa-dVOe6V1Cs/edit?gid=1587787684#gid=1587787684 and https://docs.google.com/spreadsheets/d/1b9IEGbfQjKCEaTBmcv_zyCyWEsq35StCa-dVOe6V1Cs/edit?gid=2132002234#gid=2132002234 We still have to adapt the text. Text passages to change:
About the pre-2024 versions:
|
Thanks for the detailed overview and changes @JannisBush. I finally came to checking it out and updating the text; no figures needed to be changed. Since these are relatively small changes without any impact on drawn conclusions, I think it doesn't need any disclaimer? (@tunetheweb, do you agree?) @JannisBush, I think it's a good idea to update the 2022, 2021 and 2020 articles with a disclaimer. If you run the newest query for 2021 and 2020 as well, I will update the articles with the new results. |
I had to change the query to the new The numbers for 2022 (the only year which I ran both on
|
Great, thanks a lot! Just updated the older articles, with a disclaimer. |
CI scripts identify issues with translations, and indeed, all updates to previous articles will have to be translated as well. Unfortunately, I'm no polyglot and I assume the help of GenAI will not suffice? So not sure how to handle this. |
I think the numbers in the paragraph can easily enough be updated in the other languages in this PR? For the note, running it through translate.google.com will be good enough IMHO. |
Alright, will be able to update translations this week. |
All values have been updated for the original chapter and its translations. Ready for merge. |
Some queries in the security chapter incorrectly calculated a "total" number, for example the total number of iframes only took iframes that had either an allow or sandbox attribute into account.
This pull request fixes all the queries in the security chapter with incorrect "total" numbers.
<old-tab-name> (Fixed)
)