Generate last_updated #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikegeyser
added
enhancement
mikegeyser
commented
Nov 7, 2019
| const date_string = /Date:\s+(\S*)/g.exec(stdout)[1]; | ||
| const date = new Date(date_string); | ||
|
|
||
| return date.toISOString(); |
There was a problem hiding this comment.
This uses the ISO_8601 format of representing UTC timezone with a Z, instead of +00:00. I can change this if needed.
There was a problem hiding this comment.
As per #317 (comment) think that is fine.
tunetheweb
approved these changes
Nov 7, 2019
ernee
added a commit
that referenced
this pull request
Nov 7, 2019
* Added a generate script for the last_updated timestamp. (#363) * upload cms images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #317.
This PR adds a generate script for the
last_updatedtimestamp on every content file. It is not tightly coupled to thegenerate_chaptersfunctionality, because we might want it to be a pre-commit hook instead. At the moment it will run first and uses the date of the latest commit on the file to generate thelast_modified.I'm a little nervous of the updating of source files, but I do think it's better than having to do it by hand.