Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Horizontal scrollbar #356

Merged
merged 2 commits into from
Nov 7, 2019
Merged

Horizontal scrollbar #356

merged 2 commits into from
Nov 7, 2019

Conversation

mikegeyser
Copy link
Contributor

This closes #352.

Removed the overflow:auto because it was causing a horizontal scrollbar on chrome on a mac.

@mikegeyser mikegeyser added bug Something isn't working development Building the Almanac tech stack labels Nov 7, 2019
@mikegeyser mikegeyser added this to the SHIP IT! milestone Nov 7, 2019
@mikegeyser mikegeyser self-assigned this Nov 7, 2019
@mikegeyser
Copy link
Contributor Author

Just repeating my comment for context:

It seems to be overflow: auto; set on the #chapter-navigation style. Removing it fixes the issue for me, but I'm not sure if it was put there for a reason? Is that an acceptable fix?

@rviscomi rviscomi requested review from catalinred and removed request for rviscomi, AymenLoukil and tunetheweb November 7, 2019 06:04
@catalinred
Copy link
Member

catalinred commented Nov 7, 2019 •
edited
Loading

Just repeating my comment for context:

It seems to be overflow: auto; set on the #chapter-navigation style. Removing it fixes the issue for me, but I'm not sure if it was put there for a reason? Is that an acceptable fix?

That overflow: auto; was added in order to create a block formatting context due to containing next-chapter float. Please see #315

I have tested on macOS FF, Chrome and Safari and didn't notice that horizontal scroll although I should have guessed overflow: hidden is the safer choice... 😞

So, in this case, IMO overflow: hidden; should be used instead overflow: auto to solve #352.

@catalinred catalinred mentioned this pull request Nov 7, 2019
Closed
@rviscomi rviscomi merged commit b3d919f into master Nov 7, 2019
@rviscomi rviscomi deleted the horizontal-sliding-bar-bug branch November 7, 2019 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catalinred catalinred catalinred left review comments

Assignees

@mikegeyser mikegeyser

Labels
bug Something isn't working development Building the Almanac tech stack
Projects
None yet
Milestone
SHIP IT!
Development

Successfully merging this pull request may close these issues.

Horizontal sliding bar
3 participants
@mikegeyser @catalinred @rviscomi