-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editing page weight chapter #331
Conversation
@tammyeverts @khempenius @rviscomi I've finished the editing but have a few questions and notes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Lots of comments. I think you can just do a batch commit for everything. A few require manual intervention.
A few high-level comments:
6MB
should be written as6 MB
1234%
should be written as1,234%
- figcaptions should end with a period
- headings should be sentence case, not title case
- dashes are almost always not the right punctuation, prefer commas or colons as necessary
- use ellipses sparingly (see above)
@rviscomi All the suggested changes look fine to me - however Github is saying I don't have permission to push to this repo, so you may need to do that. |
Re: combining desktop & mobile tables into one table: I personally find that type of table more difficult to read, but that's just me - I'd be fine with either style. |
Feedback Co-Authored-By: Rick Viscomi <[email protected]>
@rviscomi Thanks for the edits :)
|
Ok this is good to go. Any other changes can be filed in a new PR. Thanks everyone!! |
Progress on #218