Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation of css chapter to Japanese #3269

Merged

Conversation

ksakae1216
Copy link
Contributor

Please review for me.
Part of #586

I've also updated src/content/en/2022/css.md
Please confirm it too.

Which one should I choose about the project and milestones?

@ksakae1216 ksakae1216 added the translation world wide web label Nov 3, 2022
@ksakae1216 ksakae1216 requested review from tunetheweb and a team November 3, 2022 00:33
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

However it appears we didn't have code formatting in a lot of the descriptions in English version. I've added those to this PR, but need you to double check some of the translations as think you might have translated some of the code.

src/content/ja/2022/css.md Outdated Show resolved Hide resolved
src/content/ja/2022/css.md Show resolved Hide resolved
src/content/ja/2022/css.md Outdated Show resolved Hide resolved
src/content/ja/2022/css.md Show resolved Hide resolved
src/content/ja/2022/css.md Show resolved Hide resolved
src/content/ja/2022/css.md Show resolved Hide resolved
src/content/ja/2022/css.md Show resolved Hide resolved
src/content/ja/2022/css.md Show resolved Hide resolved
src/content/ja/2022/css.md Show resolved Hide resolved
Copy link
Contributor Author

@ksakae1216 ksakae1216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tunetheweb Fix one line

src/content/ja/2022/css.md Outdated Show resolved Hide resolved
src/content/ja/2022/css.md Show resolved Hide resolved
src/content/ja/2022/css.md Outdated Show resolved Hide resolved
src/content/ja/2022/css.md Show resolved Hide resolved
src/content/ja/2022/css.md Show resolved Hide resolved
src/content/ja/2022/css.md Show resolved Hide resolved
src/content/ja/2022/css.md Show resolved Hide resolved
src/content/ja/2022/css.md Show resolved Hide resolved
src/content/ja/2022/css.md Show resolved Hide resolved
@ksakae1216 ksakae1216 requested a review from tunetheweb November 6, 2022 00:44
@tunetheweb tunetheweb merged commit 5bf0fba into HTTPArchive:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation world wide web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants