Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the French translation 2022 Jamstack chapter #3211

Merged
merged 11 commits into from
Nov 8, 2022
Merged

Adds the French translation 2022 Jamstack chapter #3211

merged 11 commits into from
Nov 8, 2022

Conversation

Xav83
Copy link
Contributor

@Xav83 Xav83 commented Oct 9, 2022

Hi HTTPArchive devs 🙂

I am creating this Pull Request to help with the issue #539, during the Hacktoberfest, and help with the french translation.

So, in this Pull Request, I have added the french translation of the file 'src/content/en/2022/jamstackmd'. 🙂

@tunetheweb
Copy link
Member

This chapter is not completed yet, so there is little to actually translate at the moment. Do you plan to translate the full chapter when it's ready? To give an indication of the length (and so work involved) this is the 2021 file.

@tunetheweb tunetheweb marked this pull request as draft October 10, 2022 10:09
@Xav83
Copy link
Contributor Author

Xav83 commented Oct 11, 2022

Hi @tunetheweb,

Yes, I can translate the full chapter when it will be ready.
Do you know approximately when it will be ? 🙂

@tunetheweb tunetheweb changed the title Adds the french translation of the file 'src/content/en/2022/jamstack… Adds the French translation 2022 Jamstack chapter Oct 12, 2022
@tunetheweb
Copy link
Member

The Jamstack chapter has just been merged to main!

@tunetheweb tunetheweb added the translation world wide web label Oct 13, 2022
@Xav83
Copy link
Contributor Author

Xav83 commented Nov 3, 2022

A small update:

I have translated the first 100 lines of the document, and committed it (my computer show some sign of old age, and I don't want to loose this work 😆). I will be coming with the rest of the document translation in the next few days. 🙂

@Xav83
Copy link
Contributor Author

Xav83 commented Nov 6, 2022

New update

I have finish translating the document. This is the first draft, I still need to review it a couple time to see to correct the typos and mistake I may have done during the translation. When I will have done those personal reviews, I will pass the Pull Request as "Ready to review" 😉

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

A few minor things to clean up and then it looks good from my end. Though haven't checked the translation as my French is no where near good enough for that. 😁

src/content/fr/2022/jamstack.md Outdated Show resolved Hide resolved
src/content/fr/2022/jamstack.md Outdated Show resolved Hide resolved
src/content/fr/2022/jamstack.md Outdated Show resolved Hide resolved
@tunetheweb
Copy link
Member

FYI, I've staged the chapter here so you can see what it looks like, just in case you didn't get it running locally: https://20221107t104724-dot-webalmanac.uk.r.appspot.com/fr/2022/jamstack

@Xav83 Xav83 marked this pull request as ready for review November 7, 2022 20:54
@Xav83
Copy link
Contributor Author

Xav83 commented Nov 7, 2022

Hi @tunetheweb,

I have integrated the modifications you requested 🙂
And also fixed a lot of typos and errors I've made. It is now ready to be reviewed more extensively.

Excited to work with you all to make this Pull Request worthy to be merged 🤩

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Ideally we'd have another French speaker review the translation, but they've been a bit quite so I say merge and deal with any fixes later.

@tunetheweb
Copy link
Member

Oops spoke too soon. Looks like we have some linting errors due to whitespace, and also the translation is a different number of lines to English. Could you take a look @Xav83 ?

@Xav83
Copy link
Contributor Author

Xav83 commented Nov 7, 2022

Yes, I'll look into this issues 🙂 👍

@Xav83
Copy link
Contributor Author

Xav83 commented Nov 7, 2022

It should be better now 🙂

@tunetheweb tunetheweb merged commit 38360a8 into HTTPArchive:main Nov 8, 2022
@tunetheweb
Copy link
Member

And it's live!!!! 🎉

https://almanac.httparchive.org/fr/2022/jamstack

Thank you for your contribution! 🙏

@Xav83
Copy link
Contributor Author

Xav83 commented Nov 8, 2022

Thank you a lot for your help with this Pull Request @tunetheweb !
It was a great experience for me ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation world wide web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants