-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the French translation 2022 Jamstack chapter #3211
Conversation
This chapter is not completed yet, so there is little to actually translate at the moment. Do you plan to translate the full chapter when it's ready? To give an indication of the length (and so work involved) this is the 2021 file. |
Hi @tunetheweb, Yes, I can translate the full chapter when it will be ready. |
The Jamstack chapter has just been merged to main! |
A small update: I have translated the first 100 lines of the document, and committed it (my computer show some sign of old age, and I don't want to loose this work 😆). I will be coming with the rest of the document translation in the next few days. 🙂 |
New updateI have finish translating the document. This is the first draft, I still need to review it a couple time to see to correct the typos and mistake I may have done during the translation. When I will have done those personal reviews, I will pass the Pull Request as "Ready to review" 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
A few minor things to clean up and then it looks good from my end. Though haven't checked the translation as my French is no where near good enough for that. 😁
FYI, I've staged the chapter here so you can see what it looks like, just in case you didn't get it running locally: https://20221107t104724-dot-webalmanac.uk.r.appspot.com/fr/2022/jamstack |
…order of the contributors file 2022.json, as asked by @tunetheweb in the PR #3211.
Hi @tunetheweb, I have integrated the modifications you requested 🙂 Excited to work with you all to make this Pull Request worthy to be merged 🤩 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ideally we'd have another French speaker review the translation, but they've been a bit quite so I say merge and deal with any fixes later.
Oops spoke too soon. Looks like we have some linting errors due to whitespace, and also the translation is a different number of lines to English. Could you take a look @Xav83 ? |
Yes, I'll look into this issues 🙂 👍 |
It should be better now 🙂 |
And it's live!!!! 🎉 https://almanac.httparchive.org/fr/2022/jamstack Thank you for your contribution! 🙏 |
Thank you a lot for your help with this Pull Request @tunetheweb ! |
Hi HTTPArchive devs 🙂
I am creating this Pull Request to help with the issue #539, during the Hacktoberfest, and help with the french translation.
So, in this Pull Request, I have added the french translation of the file 'src/content/en/2022/jamstackmd'. 🙂