Lint templates #250
Merged
Lint templates #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd adding README section explaining how to generate chapters.
…processing will continue onto the next chapter.
rviscomi
reviewed
Oct 29, 2019
|
This also includes TOC changes. Should the destination branch be TOC as opposed to master? |
…he code comment, but prettier won't try and reformat it.
|
I do think it's a good change! Let's make it work. And sorry I accidentally pushed a commit to this branch, but it's actually semi-relevant so let's include it. I'm just rerunning the generation script and saving the markup changes. |
|
I've merged #232 into this again, and regenerated the templates to check the output. I think it's working alright now? |
|
More merge conflicts 😭 |
|
Fixed conflicts. Really sorry for the churn around these two PRs. :( |
rviscomi
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes prettier to do html reformatting and linting, so that we can catch errors in the markup at generation-time (both visually and programmatically). I've had to change some of the content files, so that the errors in them didn't break parsing.
I'm not sure if we want this at such a late stage, and I understand if this gets rejected, but I think that it will help catch and action errors sooner. (This change is built off of #232).