Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource hints 2021 markdown #2452

Merged
merged 54 commits into from
Nov 13, 2021
Merged

Resource hints 2021 markdown #2452

merged 54 commits into from
Nov 13, 2021

Conversation

kevinfarrugia
Copy link
Contributor

@kevinfarrugia kevinfarrugia commented Nov 8, 2021

Closes #2158

@kevinfarrugia kevinfarrugia added writing Related to wording and content 2021 chapter Tracking issue for a 2021 chapter labels Nov 8, 2021
src/package-lock.json Outdated Show resolved Hide resolved
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did an initial run through, concentrating mostly on technical checks. Biggest thing I noticed was inconsistent use of code formatting. Highlighted most of them but probably missed some.

Still need to do a spell check and the like but thought I'd get you started on these ones.

Looks great though so really just the finishing touches now, and sorry that it looks like a lot. Hopefully most are easy to accept. On that note, please use the "add to batch" feature in the "Files changed" tab to accept multiple suggestions in one go and add as one commit - will be quicker for you, and for GitHub CI and also mean less email noise for me! 😁

src/config/2021.json Outdated Show resolved Hide resolved
src/content/en/2021/resource-hints.md Outdated Show resolved Hide resolved
src/content/en/2021/resource-hints.md Outdated Show resolved Hide resolved
src/content/en/2021/resource-hints.md Outdated Show resolved Hide resolved
src/content/en/2021/resource-hints.md Outdated Show resolved Hide resolved
src/content/en/2021/resource-hints.md Outdated Show resolved Hide resolved
src/content/en/2021/resource-hints.md Outdated Show resolved Hide resolved
src/content/en/2021/resource-hints.md Outdated Show resolved Hide resolved
src/content/en/2021/resource-hints.md Outdated Show resolved Hide resolved
src/content/en/2021/resource-hints.md Outdated Show resolved Hide resolved
src/config/2021.json Outdated Show resolved Hide resolved
@tunetheweb tunetheweb removed the 2021 chapter Tracking issue for a 2021 chapter label Nov 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2021

Images automagically compressed by Calibre's image-actions

Compression reduced images by 42.5%, saving 28.01 KB.

Filename Before After Improvement Visual comparison
src/static/images/2021/resource-hints/rel-preconnect-adoption-by-rank.png 31.65 KB 18.72 KB -40.8% View diff
src/static/images/2021/resource-hints/rel-preload-adoption-by-rank.png 34.26 KB 19.18 KB -44.0% View diff

1027 images did not require optimisation.

src/content/en/2021/resource-hints.md Outdated Show resolved Hide resolved
src/content/en/2021/resource-hints.md Outdated Show resolved Hide resolved
src/content/en/2021/resource-hints.md Show resolved Hide resolved
Copy link
Member

@rviscomi rviscomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor grammatical suggestions and a few content suggestions.

Overall, I have to say this is an extremely well-written chapter that also has a perfect balance of historical context, contemporary stats, and expert interpretation. This was really fun to read. Nicely done @kevinfarrugia, truly!

src/content/en/2021/resource-hints.md Outdated Show resolved Hide resolved
src/content/en/2021/resource-hints.md Show resolved Hide resolved
src/content/en/2021/resource-hints.md Outdated Show resolved Hide resolved
src/content/en/2021/resource-hints.md Outdated Show resolved Hide resolved
src/content/en/2021/resource-hints.md Outdated Show resolved Hide resolved
src/content/en/2021/resource-hints.md Outdated Show resolved Hide resolved
src/content/en/2021/resource-hints.md Show resolved Hide resolved
src/content/en/2021/resource-hints.md Outdated Show resolved Hide resolved
src/content/en/2021/resource-hints.md Outdated Show resolved Hide resolved
src/content/en/2021/resource-hints.md Outdated Show resolved Hide resolved
src/content/en/2021/resource-hints.md Show resolved Hide resolved
src/content/en/2021/resource-hints.md Outdated Show resolved Hide resolved
kevinfarrugia and others added 2 commits November 12, 2021 23:04
src/content/en/2021/resource-hints.md Outdated Show resolved Hide resolved
Copy link
Member

@rviscomi rviscomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHIP IT 🚀

@rviscomi rviscomi merged commit 80e2e4a into main Nov 13, 2021
@rviscomi rviscomi deleted the resource-hints-2021-markdown branch November 13, 2021 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
writing Related to wording and content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource Hints 2021
6 participants