-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource hints 2021 markdown #2452
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did an initial run through, concentrating mostly on technical checks. Biggest thing I noticed was inconsistent use of code formatting. Highlighted most of them but probably missed some.
Still need to do a spell check and the like but thought I'd get you started on these ones.
Looks great though so really just the finishing touches now, and sorry that it looks like a lot. Hopefully most are easy to accept. On that note, please use the "add to batch" feature in the "Files changed" tab to accept multiple suggestions in one go and add as one commit - will be quicker for you, and for GitHub CI and also mean less email noise for me! 😁
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 42.5%, saving 28.01 KB.
1027 images did not require optimisation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor grammatical suggestions and a few content suggestions.
Overall, I have to say this is an extremely well-written chapter that also has a perfect balance of historical context, contemporary stats, and expert interpretation. This was really fun to read. Nicely done @kevinfarrugia, truly!
Co-authored-by: Barry Pollard <[email protected]> Co-authored-by: Rick Viscomi <[email protected]>
…hive.org into resource-hints-2021-markdown
Co-authored-by: Barry Pollard <[email protected]>
…PArchive/almanac.httparchive.org into resource-hints-2021-markdown
Co-authored-by: Weston Ruter <[email protected]> Co-authored-by: Rick Viscomi <[email protected]>
Co-authored-by: Rick Viscomi <[email protected]>
…PArchive/almanac.httparchive.org into resource-hints-2021-markdown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SHIP IT 🚀
Closes #2158