2019 Fonts chapter translation to French #2114
Conversation
|
It looks like this translation was started some time ago, and there have been many changes to the chapter since then - primarily in the meta data and the figure format. I think I still have the regexs to converts the figures so if you're OK with me doing that I can commit to this branch to bring the formats up to date with the latest version? |
|
@bazzadp sure you can commit to this branch or do you prefer that I start again forking a more recent branch from the project? |
Brought it up to date there. Also staged a version here so you can see what it looks like: https://20210404t165715-dot-webalmanac.uk.r.appspot.com/fr/2019/fonts |
| "arigaud-ca": { | ||
| "name": "Arthur Rigaud", | ||
| "teams": [ | ||
| "translators" | ||
| ], | ||
| "avatar_url": "https://avatars2.githubusercontent.com/u/50932885?v=4&s=200", | ||
| "github": "arigaud-ca", | ||
| "twitter": "arigaud_ca" | ||
| }, |
There was a problem hiding this comment.
@arigaud-ca can you confirm you're happy with this info? and or change it as you see fit.
|
Some tiny typos and harmonisations mentionned... you did great job @arigaud-ca ! :) |
|
Thanks for reviewing @nico3333fr ! @arigaud-ca , there's only a few small things to clean up here and then I think this is good to merge. Will you have a chance to close this out so we can release this? |
|
@arigaud-ca will you have time to finish this off? Very close now so would be great to be able to launch it. |
|
I've addressed most of the feedback so there really only are a few small things to fix here. @nico3333fr would you be able to finish this out if possible since @arigaud-ca seems unavailable? Keen to get this merged so it doesn't become stale or hold up any other changes. I've staged what the chapter currently looks like here: https://20210502t102616-dot-webalmanac.uk.r.appspot.com/fr/2019/fonts If there's no further update in next few days then I'll merge it as is and we can iterate on it in the future. |
|
@bazzadp I can try between tonight and tomorrow. ;) |
|
Thanks mate. Appreciated. Will hold off merging. |
|
@bazzadp added 2 suggestions. |
|
@bazzadp when I'll have the time, I'll re-read it again to have the "full picture" and do the typo-nazi, but better release, this is already a really good work :) |
First PR for Fonts 2019
I will go through another round of proofreading
Makes progress on #539