-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate 2020 Performance chapter for Traditional Chinese #1788
Conversation
Taiwan, Province of China is absolutely right, you shouldn't make this to become political problems. |
I don't see any political word in @CYBAI 's comment. He only mentioned "Taiwan is wrongly written as Taiwan, Province of China", so what's your problem ? |
why "Taiwan, Province of China" is wrong ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this - looks very good!
Not gone through it all but made some comments that should be considered for all the translation. Will review again after you've addressed these issues throughput the text.
I raised this before in another chapter (more for readability that any political concern) and this is a relevant point of the discussion:
So those are the "country names" we use in the Web Almanac even though you might not all agree with them. |
406afdd
to
532ecd3
Compare
@bazzadp Addressed your comments in the fixup commit! Please let me know if I miss anything! Thanks!
I see. Thanks for your explanation. |
@bazzadp Addressed these 2 comments in the second fixup commit! If they are okay, I will squash them into the 3rd commit for better translation review experience :) Thanks! |
We squash the commits on merge to And btw you can bulk accept suggestions in the File tab which is usually easier than accepting them one by one. Though where I have only given an example you're better to do them offline and submit as one commit. |
Ah, I see! Thanks for the information! |
d07a757
to
34c1e50
Compare
Ah, I mean squashing the fixup commits for review purpose that the second commit is the English version so that translation reviewers can just use Split view in Files while reviewing which might be easier review. so just squashed those fixup commits so that translation reviewers can check the last commit directly 🙏 still thanks for the tip! |
Can we add profiles to @CYBAI you get the credit on the chapter itself as think you did the majority of the work here - though feel free to change that, if that's not the case. I've also created a @HTTPArchive/traditional-chinese-translators group and invited you all into that so you can easily ask the full team to review any future PRs rather than adding them one by one. |
Thanks to all the revewers! I haven't gone through all the comments above but I will try to fix them or discuss with you all soon 🙇
Yes! That sounds great to me! I will help to add them into the configuration! and also the translator of this chapter of course ;)
Thank you so much :) |
@HTTPArchive/traditional-chinese-translators 以上留言的部分已經在 fixup commit 修正了!再麻煩幫忙校正!謝謝 m(_ _)m (另外我晚點會再補上 @ArvinH @aszx87410 跟 @andy0130tw 到 contributor 的 configuration!:bow:) |
Co-authored-by: aszx87410 <[email protected]>
Co-authored-by: Arvin Huang <[email protected]>
Co-authored-by: Andy Pan <[email protected]>
@ArvinH @aszx87410 @andy0130tw 已經幫你們的資料加到 2020 configuration 了!我目前是以你們的 GitHub name 跟 id 來加,另外也只有先幫你們放上 GitHub 帳號,如果有想要放 Twitter、LinkedIn 或是個人網站或是有什麼資料想要改的話,歡迎留言或是用 suggestion! |
8e3270e
to
20a42ff
Compare
Is this ready to merge apart from the contributors issue? Don't understand the Chinese so if you could mark the items as resolved once resolved that would be helpful! 😁 |
20a42ff
to
7c937c4
Compare
@bazzadp I marked all the comments as resolved and sort the contributors again! Please help me check if the sorting thing is correct or not 🙏 if yes, maybe it's ready to go if there's no other comments from translation reviewers! Thank you! |
Thanks all - looks great! |
Thanks for all reviewers! 🚀 |
Just did a release so it is live: https://almanac.httparchive.org/zh-TW/2020/performance |
@bazzadp Thank you so much! :D I can read it on the site now! |
This is part of #1106
I'd like to also ask some friends to help to review the translation in case that this post is too long 🙏
For better review experience, I committed the English version in the second commit first and then translate it in the third commit. So, you can review the 3rd commit for the translation. Wish it will help for the review experience!
cc @ArvinH @xu3u4 @jjjjackson
@bazzadp Please let me know if there's any technical part I need to update or fix!
Btw, I found
Taiwan
is wrongly written asTaiwan, Province of China
in the charts in the post. Could you help me to update them in those charts? Thank you.FWIW, in 2019,
Taiwan
was written asTaiwan
so I'm not sure why it's changed in 2020.