Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate 2020 Performance chapter for Traditional Chinese #1788

Merged
merged 9 commits into from
Dec 22, 2020

Conversation

CYBAI
Copy link
Contributor

@CYBAI CYBAI commented Dec 17, 2020

This is part of #1106


I'd like to also ask some friends to help to review the translation in case that this post is too long 🙏

For better review experience, I committed the English version in the second commit first and then translate it in the third commit. So, you can review the 3rd commit for the translation. Wish it will help for the review experience!

cc @ArvinH @xu3u4 @jjjjackson


@bazzadp Please let me know if there's any technical part I need to update or fix!

Btw, I found Taiwan is wrongly written as Taiwan, Province of China in the charts in the post. Could you help me to update them in those charts? Thank you.

FWIW, in 2019, Taiwan was written as Taiwan so I'm not sure why it's changed in 2020.

2019 2020
image image

@CYBAI CYBAI requested review from tunetheweb and AbbyTsai December 17, 2020 10:25
@tunetheweb tunetheweb added the translation world wide web label Dec 17, 2020
@tunetheweb tunetheweb added this to the 2020 Content Translation milestone Dec 17, 2020
@Zuckjet
Copy link
Contributor

Zuckjet commented Dec 17, 2020

Taiwan, Province of China is absolutely right, you shouldn't make this to become political problems.

@ByronLian
Copy link

ByronLian commented Dec 17, 2020

Taiwan, Province of China is absolutely right, you shouldn't make this to become political problems.

I don't see any political word in @CYBAI 's comment. He only mentioned "Taiwan is wrongly written as Taiwan, Province of China", so what's your problem ?

@Zuckjet
Copy link
Contributor

Zuckjet commented Dec 17, 2020

why "Taiwan, Province of China" is wrong ?

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this - looks very good!

Not gone through it all but made some comments that should be considered for all the translation. Will review again after you've addressed these issues throughput the text.

src/content/zh-TW/2020/performance.md Outdated Show resolved Hide resolved
src/content/zh-TW/2020/performance.md Outdated Show resolved Hide resolved
src/content/zh-TW/2020/performance.md Outdated Show resolved Hide resolved
src/content/zh-TW/2020/performance.md Outdated Show resolved Hide resolved
src/content/zh-TW/2020/performance.md Outdated Show resolved Hide resolved
src/content/zh-TW/2020/performance.md Outdated Show resolved Hide resolved
src/content/zh-TW/2020/performance.md Outdated Show resolved Hide resolved
src/content/zh-TW/2020/performance.md Outdated Show resolved Hide resolved
@tunetheweb
Copy link
Member

Taiwan, Province of China is absolutely right, you shouldn't make this to become political problems.

I don't see any political word in @CYBAI 's comment. He only mentioned "Taiwan is wrongly written as Taiwan, Province of China", so what's your problem ?

I raised this before in another chapter (more for readability that any political concern) and this is a relevant point of the discussion:

Country names are kind of a sensitive topic. These names are sourced from Wikipedia and included in the underlying CrUX function that maps country codes to names, so I think keeping them would be the most consistent thing, even though I agree their formatting can be a bit strange.

So those are the "country names" we use in the Web Almanac even though you might not all agree with them.

@CYBAI CYBAI force-pushed the zh-tw-performance-2020 branch 2 times, most recently from 406afdd to 532ecd3 Compare December 17, 2020 13:40
@CYBAI
Copy link
Contributor Author

CYBAI commented Dec 17, 2020

@bazzadp Addressed your comments in the fixup commit! Please let me know if I miss anything! Thanks!

So those are the "country names" we use in the Web Almanac even though you might not all agree with them.

I see. Thanks for your explanation.

src/content/zh-TW/2020/performance.md Outdated Show resolved Hide resolved
src/content/zh-TW/2020/performance.md Outdated Show resolved Hide resolved
@CYBAI
Copy link
Contributor Author

CYBAI commented Dec 17, 2020

@bazzadp Addressed these 2 comments in the second fixup commit! If they are okay, I will squash them into the 3rd commit for better translation review experience :) Thanks!

@tunetheweb
Copy link
Member

@bazzadp Addressed these 2 comments in the second fixup commit! If they are okay, I will squash them into the 3rd commit for better translation review experience :) Thanks!

We squash the commits on merge to main so don't worry about that.

And btw you can bulk accept suggestions in the File tab which is usually easier than accepting them one by one. Though where I have only given an example you're better to do them offline and submit as one commit.

@CYBAI
Copy link
Contributor Author

CYBAI commented Dec 17, 2020

@bazzadp Addressed these 2 comments in the second fixup commit! If they are okay, I will squash them into the 3rd commit for better translation review experience :) Thanks!

We squash the commits on merge to main so don't worry about that.

And btw you can bulk accept suggestions in the File tab which is usually easier than accepting them one by one. Though where I have only given an example you're better to do them offline and submit as one commit.

Ah, I see! Thanks for the information!

@CYBAI CYBAI force-pushed the zh-tw-performance-2020 branch from d07a757 to 34c1e50 Compare December 17, 2020 14:54
@CYBAI
Copy link
Contributor Author

CYBAI commented Dec 17, 2020

Ah, I mean squashing the fixup commits for review purpose that the second commit is the English version so that translation reviewers can just use Split view in Files while reviewing which might be easier review. so just squashed those fixup commits so that translation reviewers can check the last commit directly 🙏 still thanks for the tip!

src/content/zh-TW/2020/performance.md Outdated Show resolved Hide resolved
src/content/zh-TW/2020/performance.md Outdated Show resolved Hide resolved
src/content/zh-TW/2020/performance.md Outdated Show resolved Hide resolved
src/content/zh-TW/2020/performance.md Outdated Show resolved Hide resolved
@tunetheweb
Copy link
Member

Can we add profiles to config/2020.json for @ArvinH , @aszx87410 and @andy0130tw so they get credit for their help, in our Contributors page?

@CYBAI you get the credit on the chapter itself as think you did the majority of the work here - though feel free to change that, if that's not the case.

I've also created a @HTTPArchive/traditional-chinese-translators group and invited you all into that so you can easily ask the full team to review any future PRs rather than adding them one by one.

src/content/zh-TW/2020/performance.md Outdated Show resolved Hide resolved
src/content/zh-TW/2020/performance.md Outdated Show resolved Hide resolved
src/content/zh-TW/2020/performance.md Show resolved Hide resolved
src/content/zh-TW/2020/performance.md Outdated Show resolved Hide resolved
src/content/zh-TW/2020/performance.md Outdated Show resolved Hide resolved
src/content/zh-TW/2020/performance.md Show resolved Hide resolved
@CYBAI
Copy link
Contributor Author

CYBAI commented Dec 18, 2020

Thanks to all the revewers! I haven't gone through all the comments above but I will try to fix them or discuss with you all soon 🙇

Can we add profiles to config/2020.json for @ArvinH , @aszx87410 and @andy0130tw so they get credit for their help, in our Contributors page?

@CYBAI you get the credit on the chapter itself as think you did the majority of the work here - though feel free to change that, if that's not the case.

Yes! That sounds great to me! I will help to add them into the configuration! and also the translator of this chapter of course ;)

I've also created a @HTTPArchive/traditional-chinese-translators group and invited you all into that so you can easily ask the full team to review any future PRs rather than adding them one by one.

Thank you so much :)

@CYBAI
Copy link
Contributor Author

CYBAI commented Dec 20, 2020

@HTTPArchive/traditional-chinese-translators 以上留言的部分已經在 fixup commit 修正了!再麻煩幫忙校正!謝謝 m(_ _)m

(另外我晚點會再補上 @ArvinH @aszx87410@andy0130tw 到 contributor 的 configuration!:bow:)

CYBAI and others added 3 commits December 20, 2020 23:57
@CYBAI
Copy link
Contributor Author

CYBAI commented Dec 20, 2020

@ArvinH @aszx87410 @andy0130tw 已經幫你們的資料加到 2020 configuration 了!我目前是以你們的 GitHub name 跟 id 來加,另外也只有先幫你們放上 GitHub 帳號,如果有想要放 Twitter、LinkedIn 或是個人網站或是有什麼資料想要改的話,歡迎留言或是用 suggestion!

src/config/2020.json Outdated Show resolved Hide resolved
src/content/zh-TW/2020/performance.md Outdated Show resolved Hide resolved
src/content/zh-TW/2020/performance.md Outdated Show resolved Hide resolved
@CYBAI CYBAI force-pushed the zh-tw-performance-2020 branch from 8e3270e to 20a42ff Compare December 21, 2020 09:37
@tunetheweb
Copy link
Member

Is this ready to merge apart from the contributors issue? Don't understand the Chinese so if you could mark the items as resolved once resolved that would be helpful! 😁

@CYBAI CYBAI force-pushed the zh-tw-performance-2020 branch from 20a42ff to 7c937c4 Compare December 22, 2020 01:36
@CYBAI
Copy link
Contributor Author

CYBAI commented Dec 22, 2020

@bazzadp I marked all the comments as resolved and sort the contributors again! Please help me check if the sorting thing is correct or not 🙏 if yes, maybe it's ready to go if there's no other comments from translation reviewers! Thank you!

@tunetheweb
Copy link
Member

Thanks all - looks great!

@tunetheweb tunetheweb merged commit fa48f41 into HTTPArchive:main Dec 22, 2020
@CYBAI CYBAI deleted the zh-tw-performance-2020 branch December 22, 2020 14:37
@CYBAI
Copy link
Contributor Author

CYBAI commented Dec 22, 2020

Thanks for all reviewers! 🚀

@tunetheweb
Copy link
Member

Just did a release so it is live: https://almanac.httparchive.org/zh-TW/2020/performance

@CYBAI
Copy link
Contributor Author

CYBAI commented Dec 22, 2020

@bazzadp Thank you so much! :D I can read it on the site now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation world wide web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants