Resource Hints 2020 edits #1664

exterkamp · 2020-12-07T22:50:34Z

Progress on #920 #1432 cc @Zizzamia

Editors notes:

Edits, round 2
Final spellcheck
Check print layout

src/content/en/2020/resource-hints.md

exterkamp · 2020-12-08T04:42:20Z

src/content/en/2020/resource-hints.md

  content="3.87%",
  classes="big-number",
  sheets_gid="2039808014",
  sql_file="native_lazy_loading_attrs.sql"
 ) }}

-{# TODO - revisit this figure - Ref https://github.com/HTTPArchive/almanac.httparchive.org/pull/1587#discussion_r532292106 #}
+{# TODO(authors) - revisit this figure - Ref https://github.com/HTTPArchive/almanac.httparchive.org/pull/1587#discussion_r532292106 #}


Not quite sure what's the split between images vs iframe based on native_lazy_loading_attrs.sql.

@khempenius can you helps us clarify more about this data, @bazzadp was asking about it here #1587

src/content/en/2020/resource-hints.md

Zizzamia · 2020-12-08T09:07:41Z

src/content/en/2020/resource-hints.md


-{# TODO - revisit this sentence - Ref https://github.com/HTTPArchive/almanac.httparchive.org/pull/1587#discussion_r532291496 #}
+{# TODO(authors/reviewers) - revisit this sentence - Ref https://github.com/HTTPArchive/almanac.httparchive.org/pull/1587#discussion_r532291496 #}


I removed the part where we say which is an astonishing result, but @bazzadp related to your comment #1587 (comment), I am not sure at this point how to surface this information. How you think is best we share it?

exterkamp

Things are looking good! I think we're on the home stretch!

src/content/en/2020/resource-hints.md

exterkamp · 2020-12-09T04:05:55Z

src/content/en/2020/resource-hints.md

@@ -199,9 +205,10 @@ Be mindful that fonts preloaded without the `crossorigin` attribute will be fetc

 When it's time to choose a resource for use with different screen sizes, reach for the `media` attribute with `preload` to optimize your media queries.

+{# TODO(editors): Should we keep this shorter to prevent small amounts of scrolling? #}


This might also be a question for @Zizzamia because desktop/mobile.css may be relevant to the example.

Generally, I'm ok with code scrolling, we have an overflow style to handle it.

The reason I suggest removing the scroll from here is because it is so small it's almost distracting and has little to no useful content behind the scroll:

Only these 2 characters are hidden.

I just find it more aesthetic to not have scrolling for something this minor.

The scroll area would depend on users' viewport size so it may be more or less. I wouldn't worry about it.

exterkamp · 2020-12-09T04:06:23Z

src/content/en/2020/resource-hints.md

  classes="big-number",
  sheets_gid="2039808014",
  sql_file="native_lazy_loading_attrs.sql"
 ) }}

-{# TODO - revisit this figure - Ref https://github.com/HTTPArchive/almanac.httparchive.org/pull/1587#discussion_r532292106 #}
+{# TODO(authors/reviewers) - revisit this figure - Ref https://github.com/HTTPArchive/almanac.httparchive.org/pull/1587#discussion_r532292106 #}


I was looking more over #1587 (comment) and I am not super sure if the query we run does make a distinction between iframe or img. Maybe @rviscomi or @khempenius can help a bit more with it. cc @bazzadp

src/content/en/2020/resource-hints.md

exterkamp · 2020-12-09T04:07:34Z

src/content/en/2020/resource-hints.md


 The largest use is with script elements, which is unsurprising as the number of JS primary and third-party files continues to grow.

+{# TODO(authors): Make sure the query link is correct, and that the gid is correct. #}


The gid is correct (1098063134), and the I think this is the right query https://github.com/HTTPArchive/almanac.httparchive.org/blob/main/sql/2020/21_Resource_Hints/priority_hints_by_importance.sql as mentioned in the figure. Right @khempenius @rviscomi ?

src/content/en/2020/resource-hints.md

exterkamp · 2020-12-09T04:18:30Z

src/content/en/2020/resource-hints.md

-  caption="Adoption of resource hints",
-  description="TODO",
+  caption="Adoption of resource hints.",
+  description="A bar chart of the rate of resource hint adoption broken down by hint type and form factor. For desktop, 33% of pages use the `dns-prefetch` resource hint, 18% use `preload`, 8% use `preconnect`, 3% use `prefetch`, and less than 1% use `prerender`. Mobile is similar, except that `dns-prefetch` has 34% usage (1% higher), and `preconnect` has 9% (1% higher).",


Sorry, @Zizzamia I should have linked you to the "description" guidance. I reworded them, make sure you think they are appropriate.

Oh I seeeee! Thank you for taking care of it.

rviscomi

LGTM. We can remove the unedited flag when this is merged.

If we don't hear from @Zizzamia tonight, are there any changes that you'd be uncomfortable merging without his OK? If so let's consider changing them to TODOs and merging the rest.

Great job and thanks for the thorough edit!

src/content/en/2020/resource-hints.md

exterkamp · 2020-12-09T06:22:45Z

This is the only comment that I am unsure of and might need a more thorough look.

#1664 (comment)

src/content/en/2020/resource-hints.md

Co-authored-by: Rick Viscomi <[email protected]>

Zizzamia · 2020-12-09T07:08:50Z

Alright, love the edits! Thank you @exterkamp and @rviscomi, I guess time to merge and deploy to prod 🔥🚀🌕

Zizzamia

🌲🚀🌕

exterkamp · 2020-12-09T08:35:59Z

@Zizzamia this figure looks like it is using a serif'd typeface in print view:

(src/static/images/2020/resource-hints/mobile-as-attribute-values-by-year.png)

tunetheweb · 2020-12-09T08:48:48Z

@Zizzamia this figure looks like it is using a serif'd typeface in print view:
(src/static/images/2020/resource-hints/mobile-as-attribute-values-by-year.png)

Think I did these so let me know when you're done and I'll fix this (and then just go ahead and merge this after ready for launch!)

exterkamp mentioned this pull request Dec 7, 2020

Edit 2020 Chapters #1432

Closed

22 tasks

rviscomi added the editing Content excellence label Dec 7, 2020

rviscomi added this to the 2020 Content Writing milestone Dec 7, 2020

exterkamp commented Dec 8, 2020

View reviewed changes

exterkamp requested a review from Zizzamia December 8, 2020 04:45

exterkamp marked this pull request as ready for review December 8, 2020 04:45

rviscomi mentioned this pull request Dec 8, 2020

[wip]fix: resource hints TODOs #1667

Closed

exterkamp and others added 10 commits December 8, 2020 00:37

Spelling corrections and basic markdown corrections.

26dd41a

Replace smart quotes.

10181c5

Fix author bio key.

8f7365a

First pass edits.

8ccd8d1

<a/> to </a>

510b73d

Oxford comma check.

35e8856

Editing figures, esp. captions.

672d0da

fix: image one

d214c3c

fix: added image two

5b2c943

fix: added image three

972c73a

Zizzamia force-pushed the resource-hints-edits branch from c952ff4 to 972c73a Compare December 8, 2020 08:39

Zizzamia added 3 commits December 8, 2020 00:43

fix: removed extra figure from as chapter

1cf9a6c

fix: media code

df71792

fix: uses-rel-preload

e1c7b7e

Zizzamia reviewed Dec 8, 2020

View reviewed changes

Zizzamia added 3 commits December 8, 2020 01:11

fix: Lighthouse audit section clean up

9a1baf5

fix: added final image

1e7f49e

chore: done for today :)

da51b54

rviscomi added the ASAP This issue is blocking progress label Dec 8, 2020

rviscomi assigned Zizzamia and exterkamp Dec 8, 2020

Edits round 2.

784bd1a

exterkamp added 5 commits December 8, 2020 19:14

Add some links, adjust some wording, use proper noun Priority Hints.

1c0e24c

Remove old TODO.

e4ddbea

Unify all big-number captions to use 'The percent...'

7d991c3

Add chart descriptions.

9fb5f65

79 -> 83, more TODO clarifications.

0b6db96

exterkamp commented Dec 9, 2020

View reviewed changes

exterkamp requested review from Zizzamia and rviscomi December 9, 2020 04:32

rviscomi approved these changes Dec 9, 2020

View reviewed changes

src/content/en/2020/resource-hints.md Outdated Show resolved Hide resolved

Zizzamia reviewed Dec 9, 2020

View reviewed changes

src/content/en/2020/resource-hints.md Show resolved Hide resolved

Zizzamia and others added 4 commits December 8, 2020 22:50

fix: crossorigin big-number

1ad5bb1

chore: removed todos

f0f8744

chore: resolved todo

57366aa

feat: remove unedited line

9bb6480

Co-authored-by: Rick Viscomi <[email protected]>

Zizzamia approved these changes Dec 9, 2020

View reviewed changes

Spellcheck

50716d0

exterkamp requested a review from Zizzamia December 9, 2020 08:36

chore: remove TODOs.

371e51c

tunetheweb added 2 commits December 9, 2020 10:41

Fix image

8cc5772

Merge branch 'main' into resource-hints-edits

26b80a3

tunetheweb merged commit ba53db9 into main Dec 9, 2020

tunetheweb deleted the resource-hints-edits branch December 9, 2020 11:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Resource Hints 2020 edits #1664

Resource Hints 2020 edits #1664

exterkamp commented Dec 7, 2020 •

edited

Loading

exterkamp Dec 8, 2020

Zizzamia Dec 8, 2020

Zizzamia Dec 8, 2020

exterkamp left a comment

exterkamp Dec 9, 2020

rviscomi Dec 9, 2020

exterkamp Dec 9, 2020

rviscomi Dec 9, 2020

exterkamp Dec 9, 2020

Zizzamia Dec 9, 2020

exterkamp Dec 9, 2020

Zizzamia Dec 9, 2020

exterkamp Dec 9, 2020

Zizzamia Dec 9, 2020

rviscomi left a comment

exterkamp commented Dec 9, 2020

Zizzamia commented Dec 9, 2020

Zizzamia left a comment

exterkamp commented Dec 9, 2020

tunetheweb commented Dec 9, 2020


		{# TODO - revisit this sentence - Ref https://github.com/HTTPArchive/almanac.httparchive.org/pull/1587#discussion_r532291496 #}
		{# TODO(authors/reviewers) - revisit this sentence - Ref https://github.com/HTTPArchive/almanac.httparchive.org/pull/1587#discussion_r532291496 #}

		@@ -199,9 +205,10 @@ Be mindful that fonts preloaded without the `crossorigin` attribute will be fetc

		When it's time to choose a resource for use with different screen sizes, reach for the `media` attribute with `preload` to optimize your media queries.

		{# TODO(editors): Should we keep this shorter to prevent small amounts of scrolling? #}


		The largest use is with script elements, which is unsurprising as the number of JS primary and third-party files continues to grow.

		{# TODO(authors): Make sure the query link is correct, and that the gid is correct. #}

Resource Hints 2020 edits #1664

Resource Hints 2020 edits #1664

Conversation

exterkamp commented Dec 7, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

exterkamp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rviscomi left a comment

Choose a reason for hiding this comment

exterkamp commented Dec 9, 2020

Zizzamia commented Dec 9, 2020

Zizzamia left a comment

Choose a reason for hiding this comment

exterkamp commented Dec 9, 2020

tunetheweb commented Dec 9, 2020

exterkamp commented Dec 7, 2020 •

edited

Loading