Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2020 Accessibility chapter #1659

Merged
merged 51 commits into from
Dec 9, 2020
Merged

2020 Accessibility chapter #1659

merged 51 commits into from
Dec 9, 2020

Conversation

oluoluoxenfree
Copy link
Contributor

@oluoluoxenfree oluoluoxenfree commented Dec 7, 2020

Progress on #907

@rviscomi rviscomi changed the title Add author bio 2020 Accessibility chapter Dec 7, 2020
@rviscomi rviscomi added the writing Related to wording and content label Dec 7, 2020
@rviscomi rviscomi added this to the 2020 Content Writing milestone Dec 7, 2020
@rviscomi
Copy link
Member

rviscomi commented Dec 7, 2020

Thanks @oluoluoxenfree! I'll mark this PR as a draft while the rest of the markdown is converted. Please mark it "ready for review" when the conversion is complete.

@rviscomi rviscomi marked this pull request as draft December 7, 2020 20:12
@rviscomi rviscomi added the ASAP This issue is blocking progress label Dec 8, 2020
@rviscomi
Copy link
Member

rviscomi commented Dec 8, 2020

@oluoluoxenfree I've pushed a change to this branch to fix up some of the figures, giving them the correct semantic markup. There are some TODOs in there for you to resolve as well.

All, please pitch in if you can and suggest changes or push them directly to the branch. We need to get this markdown completed and submitted by the end of the day to be published in the morning.

@rviscomi rviscomi marked this pull request as ready for review December 8, 2020 18:51

It is important to ensure that form labels have a programmatic association with their respective inputs. It is not sufficient to just display the label visually. We found that only 26.51% of sites have all of their labels properly associated with their respective inputs (achieved with a `for`/`id` relationship or inputs nested inside labels).

Groups of form controls such as a set of radio inputs or checkboxes should be nested as the first child within a `<fieldset>` element and given a group label via the `<legend>` element within the `<fieldset>`. The individual controls still need to be programmatically associated with their respective visible labels as well.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Groups of form controls such as a set of radio inputs or checkboxes should be nested as the first child within a <fieldset> element and given a group label via the <legend> element within the <fieldset>."

The <legend> should be the first child, not the fields.

This may be my fault, since I explained it and missed it on review. Maybe dump the first child reference altogether.

Copy link
Contributor

@aardrian aardrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left notes throughout.

This looks great overall. Thrilled to see how it came together.

@foxdavidj
Copy link
Contributor

@oluoluoxenfree looking through the document, I'm not seeing any indications of what charts and graphs you'd like to display from our analysis, and where you'd like them.

Can you go back through the document and put the following wherever you'd like a figure?

{# TODO: <Description of figure you'd like to display> #}

Copy link
Contributor

@aardrian aardrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I did it correctly this time.

src/content/en/2020/accessibility.md Outdated Show resolved Hide resolved
src/content/en/2020/accessibility.md Outdated Show resolved Hide resolved
src/content/en/2020/accessibility.md Outdated Show resolved Hide resolved
src/content/en/2020/accessibility.md Outdated Show resolved Hide resolved
src/content/en/2020/accessibility.md Outdated Show resolved Hide resolved
src/content/en/2020/accessibility.md Outdated Show resolved Hide resolved
src/content/en/2020/accessibility.md Outdated Show resolved Hide resolved
src/content/en/2020/accessibility.md Outdated Show resolved Hide resolved
src/content/en/2020/accessibility.md Outdated Show resolved Hide resolved
src/content/en/2020/accessibility.md Outdated Show resolved Hide resolved
alextait1 and others added 21 commits December 8, 2020 23:25
@rviscomi rviscomi merged commit 45b339f into main Dec 9, 2020
@rviscomi rviscomi deleted the accessibility-2020 branch December 9, 2020 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASAP This issue is blocking progress writing Related to wording and content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants