-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2020 Accessibility chapter #1659
Conversation
Thanks @oluoluoxenfree! I'll mark this PR as a draft while the rest of the markdown is converted. Please mark it "ready for review" when the conversion is complete. |
@oluoluoxenfree I've pushed a change to this branch to fix up some of the figures, giving them the correct semantic markup. There are some TODOs in there for you to resolve as well. All, please pitch in if you can and suggest changes or push them directly to the branch. We need to get this markdown completed and submitted by the end of the day to be published in the morning. |
src/content/en/2020/accessibility.md
Outdated
|
||
It is important to ensure that form labels have a programmatic association with their respective inputs. It is not sufficient to just display the label visually. We found that only 26.51% of sites have all of their labels properly associated with their respective inputs (achieved with a `for`/`id` relationship or inputs nested inside labels). | ||
|
||
Groups of form controls such as a set of radio inputs or checkboxes should be nested as the first child within a `<fieldset>` element and given a group label via the `<legend>` element within the `<fieldset>`. The individual controls still need to be programmatically associated with their respective visible labels as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Groups of form controls such as a set of radio inputs or checkboxes should be nested as the first child within a <fieldset>
element and given a group label via the <legend>
element within the <fieldset>
."
The <legend>
should be the first child, not the fields.
This may be my fault, since I explained it and missed it on review. Maybe dump the first child reference altogether.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left notes throughout.
This looks great overall. Thrilled to see how it came together.
@oluoluoxenfree looking through the document, I'm not seeing any indications of what charts and graphs you'd like to display from our analysis, and where you'd like them. Can you go back through the document and put the following wherever you'd like a figure?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I did it correctly this time.
Co-authored-by: Adrian Roselli <[email protected]>
Co-authored-by: Adrian Roselli <[email protected]>
Co-authored-by: Adrian Roselli <[email protected]>
Co-authored-by: Adrian Roselli <[email protected]>
Co-authored-by: Adrian Roselli <[email protected]>
Co-authored-by: Adrian Roselli <[email protected]>
Co-authored-by: Adrian Roselli <[email protected]>
Co-authored-by: Adrian Roselli <[email protected]>
Co-authored-by: Adrian Roselli <[email protected]>
Co-authored-by: Adrian Roselli <[email protected]>
Co-authored-by: Adrian Roselli <[email protected]>
Co-authored-by: Adrian Roselli <[email protected]>
Co-authored-by: Adrian Roselli <[email protected]>
Co-authored-by: Adrian Roselli <[email protected]>
Co-authored-by: Adrian Roselli <[email protected]>
Co-authored-by: Adrian Roselli <[email protected]>
Co-authored-by: Adrian Roselli <[email protected]>
Co-authored-by: Adrian Roselli <[email protected]>
Co-authored-by: Adrian Roselli <[email protected]>
Co-authored-by: Adrian Roselli <[email protected]>
Co-authored-by: Adrian Roselli <[email protected]>
Progress on #907