Update the post-launch 2020 home page #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Well that's a mistake on my part! We shouldn't have 2019 data in the base templates. Saying that, if you're going to reuse the exact same wording other than number of chapters then let's generalise this! This is done in ebe977d Also solves the translation issue. |
17 tasks
tunetheweb
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #1630
This PR does not update non-English languages (help with that would be appreciated). Note that "20 chapters" is baked into the year-agnostic base template, which means that the
2020/index.htmltemplate needs to overwrite themissionblock.