Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyedit of the CMS 2020 Chapter #1624

Merged
merged 3 commits into from
Dec 4, 2020
Merged

Copyedit of the CMS 2020 Chapter #1624

merged 3 commits into from
Dec 4, 2020

Conversation

tunetheweb
Copy link
Member

@tunetheweb tunetheweb commented Dec 3, 2020

Progress on #1432

I made the following changes:

  • Moved the "goal of this chapter" section into the Introduction as otherwise looked like we had two intros
  • Change tables to HTML to allow numeric formatting
  • Normalised Smart Quotes as per Use of typographic quotes or "smart quotes" in the Web Almanac #1485 and changed "it's" to "it is"
  • Removed some use of semi-colons that I felt were separate sentences to improve readability
  • Created a "Chrome User Experience Report" heading to better group and differentiate the CrUX and Lighthouse data
  • Add @rviscomi 's more positive spin as discussed in 2020 CMS Chapter #1513 (comment)
  • Fixed and added more links
  • Removed labels from two graphs from 1 axis for readability (included new fallback images in this PR).
  • Removed the "unedited" flag! 🎉

This version of the chapter is staged here: https://20201203t160104-dot-webalmanac.uk.r.appspot.com/en/2020/cms

@alexdenning this is the last stage and then the chapter is complete and ready to publish for next week's launch. So if you could review the changes to make sure you're comfortable with them!

In particular it would be helpful for you to review:

@tunetheweb tunetheweb added the editing Content excellence label Dec 3, 2020
@tunetheweb tunetheweb added this to the 2020 Content Writing milestone Dec 3, 2020
@tunetheweb tunetheweb mentioned this pull request Dec 3, 2020
22 tasks
@rviscomi rviscomi requested a review from alexdenning December 3, 2020 16:26
@alexdenning
Copy link
Contributor

@bazzadp @rviscomi many thanks, and apologies for being slow – been very busy with work this week. I've had a look through and that all looks good to go, so no further suggestions from me! Cheers.

@tunetheweb tunetheweb merged commit e185b20 into main Dec 4, 2020
@tunetheweb tunetheweb deleted the cms_2020_editing branch December 4, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editing Content excellence
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants