-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caching 2020 queries #1318
Caching 2020 queries #1318
Conversation
@HTTPArchive/analysts have added the first sql file, request review (percentiles of TTL by resource type, client - desktop or mobile). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Query itself is fine. Added a couple of comments on convention that you should follow.
Let us know if any of that is not clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial query LGTM.
Added a new blank line at the end.
@HTTPArchive/analysts request review of ttl_by_resource_third_party, resource_without_cache, and resource_without_cache_third_party. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments but looks like queries are good so no need to submit in smaller batches and just request a re-review when rest are done.
@raghuramakrishnan71 is this everything? If so I'll give this a thorough review. Otherwise ping this PR when you've added all of the queries. |
📟 ping @raghuramakrishnan71 |
Updated the SQLs after validating with Chapter contents. @HTTPArchive/analysts |
Results saved to the Caching sheet. |
(rviscomi: moved TODO list to the top comment for easier tracking) |
hello, saw some of our metrics may be similar enough to combine as one. here is reference items, and like to hear your thoughts if you get other ideas. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raghuramakrishnan71 getting closer. Let's resolve these last few remaining comments and merge and iterate as needed.
Co-authored-by: Rick Viscomi <[email protected]>
Co-authored-by: Rick Viscomi <[email protected]>
Co-authored-by: Rick Viscomi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these look well to me and found a passion inside.
@AbbyTsai - i checked out the compression queries, which are using $.audits.uses-text-compression.score, in the main branch. I am trying to explore if there is a caching specific score (maybe uses-long-cache-ttl) and savings in bytes. Agree, the query may look similar to 19_02, 19_04 as the report field of the lighthouse table is already being used. |
Merging this to keep it moving. @raghuramakrishnan71 please open up a new PR if there are any more follow up changes needed. |
Queries for the Caching chapter. Progress on #917
Carried forward the open list to #1498
Todo query list
Todo document list