Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty image formats #1262

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Fix empty image formats #1262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/util/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

This directory contains utilities for managing the Web Almanac dataset on BigQuery.

## [summary_requests.sql](./summary_requests.sql)
## [requests.sql](./requests.sql)

This query generates summary metadata about each request from its JSON-encoded HAR object. For every Web Almanac crawl (eg 2019_07_01 and 2020_08_01) this query should be run once and configured to have its results appended to the `almanac.requests` table. This table is useful for Web Almanac analysis because it combines the metadata of the request with the HAR payload, more easily enabling queries that segment requests by resource type (script, style, image) and base HTML page.

Expand Down
1 change: 1 addition & 0 deletions sql/util/summary_requests.sql → sql/util/requests.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ LANGUAGE js AS """
return 'other';
}
function getFormat(prettyType, mimeType, ext) {
ext = ext.toLowerCase();
if (prettyType == 'image') {
for (type of ['jpg', 'png', 'gif', 'webp', 'svg', 'ico']) {
if (mimeType.includes(type) || ext == type) {
Expand Down