Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portuguese translation of base template #1213

Merged
merged 28 commits into from
Aug 14, 2020

Conversation

HakaCode
Copy link
Contributor

I hope I did everything correctly.

Makes progress on #505

HakaCode and others added 27 commits August 2, 2020 20:35
Portuguese translation of base template "Base_chapter.html"

Makes progress on HTTPArchive#505
@HakaCode HakaCode requested a review from tunetheweb August 14, 2020 01:28
@HakaCode HakaCode added the translation world wide web label Aug 14, 2020
@rviscomi rviscomi added this to the 2020 Content Translation milestone Aug 14, 2020
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small correction please!

BTW, see my Git Guide for ways to avoid that long commit trail

src/templates/pt/2019/base_chapter.html Outdated Show resolved Hide resolved
@HakaCode
Copy link
Contributor Author

Just one small correction please!

BTW, see my Git Guide for ways to avoid that long commit trail

Yes, i spent hours trying to learn by reading and putting it into practice even though i have never seen it, sometimes i get lost with some commands, however, i haven’t done so far, i use Google Translate :)

@tunetheweb tunetheweb merged commit 863aed7 into HTTPArchive:main Aug 14, 2020
@HakaCode HakaCode deleted the Completed_pt_translation branch August 14, 2020 16:32
@HakaCode
Copy link
Contributor Author

HakaCode commented Aug 14, 2020

@bazzadp could you guide me on this? I am following the guide you gave me, but I cannot proceed.

$ git fetch upstream
[email protected]: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

@tunetheweb
Copy link
Member

This suggests you haven’t set up your ssh key. We’re you using https access to the repo (did you have to type password each time you wanted to push changes?)?

If so, then you needed to add upstream in the same way using https instead of git.

You can switch this to https, using:

git remote set-url upstream https://github.com/HTTPArchive/almanac.httparchive.org.git

It us worth looking into setting up SSH keys though and using [email protected] addresses instead of https://github.com. Much better as don’t have to type your password each time.

@tunetheweb
Copy link
Member

tunetheweb commented Aug 14, 2020

This suggests you haven’t set up your ssh key. Are you using https access to the repo (did you have to type password each time you wanted to push changes?)?

Type this to see:
git remote -v

If it’s set using https://github.com addresses instead of [email protected] addresses, then you needed to add upstream in the same way using https instead of git.

You can switch this to https, using:

git remote set-url upstream https://github.com/HTTPArchive/almanac.httparchive.org.git

It us worth looking into setting up SSH keys though and using [email protected] addresses instead of https://github.com. Much better as don’t have to type your password each time.

@HakaCode
Copy link
Contributor Author

I got it, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation world wide web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants