Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow home page #1191

Merged
merged 12 commits into from
Aug 10, 2020
Merged

Conversation

catalinred
Copy link
Member

@catalinred catalinred commented Aug 10, 2020

This fixes #574

  • Please note that all the .html changes are due to wrapping the content into .container.
    This is related to removing the .container wrapper from base.html as the index is based on a CSS grid structure.
  • Enhanced the contributors block on wide displays as well.
  • Organized a bit the MQ's from index.css and removed some redundant lines

@catalinred catalinred force-pushed the home-page-wide-monitors branch from fd3f92a to 2d5a363 Compare August 10, 2020 11:01
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks a LOT better!

However spotted one issue on mobile and want to discuss the container change more.

src/static/css/index.css Show resolved Hide resolved
src/templates/base/2019/base.html Outdated Show resolved Hide resolved
@rviscomi rviscomi added the development Building the Almanac tech stack label Aug 10, 2020
@rviscomi rviscomi added this to the 2020 Platform Development milestone Aug 10, 2020
@catalinred
Copy link
Member Author

Not strictly related to this PR, but I've noticed two things:

  • the /table-of-contents and /contributors are adding extra 10px sides padding, I think this is extra, unless this is not intended perhaps for the ebook pages?

  • On the /2019/ page, for the sake of readability and UX, would love to see the intro phrase split into multiple paragraphs, as in /2020/ perhaps, what do you think? Same for the Featured Chapter text as well.

@tunetheweb
Copy link
Member

  • the /table-of-contents and /contributors are adding extra 10px sides padding, I think this is extra, unless this is not intended perhaps for the ebook pages?

The ebook reimplements the contents for those two pieces in base/2019/base_ebook.html so doesn’t use those two templates at all. So guessing extra?

  • On the /2019/ page, for the sake of readability and UX, would love to see the intro phrase split into multiple paragraphs, as in /2020/ perhaps, what do you think? Same for the Featured Chapter text as well.`

Yeah I could go with that. Though then need to look at all languages. Maybe better as a separate follow up PR after we merge this one? And btw still disagree with @rviscom’s decision to put 2020 temporary text in italics 😀

Leave featured chapter alone btw as lots going on for that in other branches/PRs.

@catalinred
Copy link
Member Author

So guessing extra?

I did remove the extra CSS lines.

better as a separate follow up PR

Sure thing.

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice bit of clean up @catalinred - well done!

@rviscomi let me know if you want to review too or happy for me to merge?

@rviscomi
Copy link
Member

Go ahead and merge. Thanks @catalinred!

@tunetheweb tunetheweb merged commit ac599b6 into HTTPArchive:main Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Building the Almanac tech stack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize website for wide viewports
3 participants