-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Narrow home page #1191
Narrow home page #1191
Conversation
This is redundant now.
Ordered MQs in logical order. Removed redundant CSS code.
fd3f92a
to
2d5a363
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks a LOT better!
However spotted one issue on mobile and want to discuss the container change more.
Not strictly related to this PR, but I've noticed two things:
|
The ebook reimplements the contents for those two pieces in
Yeah I could go with that. Though then need to look at all languages. Maybe better as a separate follow up PR after we merge this one? And btw still disagree with @rviscom’s decision to put Leave featured chapter alone btw as lots going on for that in other branches/PRs. |
Minimize the HTML changes
I did remove the extra CSS lines.
Sure thing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice bit of clean up @catalinred - well done!
@rviscomi let me know if you want to review too or happy for me to merge?
Go ahead and merge. Thanks @catalinred! |
This fixes #574
.html
changes are due to wrapping the content into.container
.This is related to removing the
.container
wrapper frombase.html
as the index is based on a CSS grid structure.