Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portuguese translation of base template #1146

Merged
merged 25 commits into from
Aug 5, 2020
Merged

Conversation

HakaCode
Copy link
Contributor

@HakaCode HakaCode commented Aug 3, 2020

My first PR in this repo!
I hope I did everything correctly.

Makes progress on #505

@HakaCode HakaCode added the translation world wide web label Aug 3, 2020
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, however make sure you keep the line numbers consistent with English - it makes it easier to compare results and make technical changes in future for non-Portugues speakers.

src/templates/pt/2019/base.html Outdated Show resolved Hide resolved
src/templates/pt/2019/base.html Outdated Show resolved Hide resolved
src/templates/pt/2019/base.html Outdated Show resolved Hide resolved
src/templates/pt/2019/base.html Outdated Show resolved Hide resolved
src/templates/pt/2019/base.html Outdated Show resolved Hide resolved
src/templates/pt/2019/base.html Outdated Show resolved Hide resolved
src/templates/pt/2019/base.html Outdated Show resolved Hide resolved
src/templates/pt/2019/base.html Outdated Show resolved Hide resolved
src/templates/pt/2019/base.html Outdated Show resolved Hide resolved
src/templates/pt/2019/base.html Outdated Show resolved Hide resolved
@tunetheweb tunetheweb added this to the 2019 Backlog milestone Aug 3, 2020
@tunetheweb tunetheweb changed the title Portuguese translation,Makes progress on #505 Portuguese translation of base template Aug 3, 2020
Copy link
Contributor Author

@HakaCode HakaCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accepted suggestion

@HakaCode HakaCode self-assigned this Aug 4, 2020
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @HakaCode changes added to this branch are automatically added to the pull request. You can use the little circle icon to re-request a review:

Re-request a review

Or just comment like you did and anyone on the thread already should see it 😀

I spotted a small number of things to fix, but also made a larger number of suggestions to use <i lang="en"></i> around English phrases so screen readers and the like know to pronounce them in English.

After those are addressed I think we can merge this!

src/templates/pt/2019/base.html Outdated Show resolved Hide resolved
src/templates/pt/2019/base.html Show resolved Hide resolved
src/templates/pt/2019/base.html Outdated Show resolved Hide resolved
src/templates/pt/2019/base.html Outdated Show resolved Hide resolved
src/templates/pt/2019/base.html Outdated Show resolved Hide resolved
src/templates/pt/2019/base.html Show resolved Hide resolved
src/templates/pt/2019/base.html Outdated Show resolved Hide resolved
src/templates/pt/2019/base.html Outdated Show resolved Hide resolved
src/templates/pt/2019/base.html Outdated Show resolved Hide resolved
src/templates/pt/2019/base.html Show resolved Hide resolved
Copy link
Contributor Author

@HakaCode HakaCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accepted suggestions

src/templates/pt/2019/base.html Show resolved Hide resolved
src/templates/pt/2019/base.html Show resolved Hide resolved
@HakaCode HakaCode requested a review from tunetheweb August 5, 2020 19:40
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM now so let’s merge.

@tunetheweb tunetheweb merged commit cc07e63 into HTTPArchive:main Aug 5, 2020
@tunetheweb
Copy link
Member

Thanks for that. Looking forward to getting more of it translated! 🇧🇷

Btw noticed you are using the main branch of your fork. I wrote something up recently on why I think it’s better not to do that: https://github.com/HTTPArchive/almanac.httparchive.org/wiki/Git-Guide#recommended-way-to-use-git-for-the-web-almanac

@HakaCode
Copy link
Contributor Author

HakaCode commented Aug 5, 2020

Obrigado por isso. Ansioso para obter mais do que traduzido!🇧🇷

Btw percebeu que você está usando o mainramo do seu garfo. Escrevi recentemente algo sobre por que acho que é melhor não fazer isso: https://github.com/HTTPArchive/almanac.httparchive.org/wiki/Git-Guide#recommended-way-to-use-git-for- o almanaque da web

Thanks for accepting, in case I do something wrong in the future you can tell me, and also thanks for Patience with the newbie.

@tunetheweb
Copy link
Member

Wrong is the wrong word - this is very much a matter of opinion here. But have a read of that and see if you can understand why I suggest what I did. Happy to answer any questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation world wide web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants