Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chapter 5: Add All Byte and Request Count Queries #107

Merged
merged 10 commits into from
Aug 15, 2019
Merged

Chapter 5: Add All Byte and Request Count Queries #107

merged 10 commits into from
Aug 15, 2019

Conversation

patrickhulce
Copy link
Contributor

@patrickhulce patrickhulce commented Jul 29, 2019 •
edited
Loading

I hope this is the expected format. From #62 (comment) it sounds like we prefer duplication for easy of reading (many queries differ only in their ORDER BY clause or could easily be combined when run). Should this be called out in a comment perhaps?

ref #86

@rviscomi rviscomi mentioned this pull request Jul 29, 2019
Closed
13 tasks
@patrickhulce patrickhulce added the analysis Querying the dataset label Jul 29, 2019
@patrickhulce
Copy link
Contributor Author

@simonhearne @flowlabs @jasti @zeman any desire to review these query PRs, or shall I only ping y'all for the article content phase?

@rviscomi rviscomi added this to the Content written milestone Jul 31, 2019
rviscomi
rviscomi reviewed Jul 31, 2019
View reviewed changes
sql/2019/05_Third_Parties/05_06.sql Show resolved Hide resolved
sql/2019/05_Third_Parties/05_06.sql Outdated Show resolved Hide resolved
sql/2019/05_Third_Parties/05_06.sql Outdated Show resolved Hide resolved
sql/2019/05_Third_Parties/05_06.sql Outdated
NET.HOST(url) AS requestDomain,
DomainsOver50Table.requestDomain as thirdPartyDomain
FROM
`httparchive.requests.2019_07_01_mobile`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you also want to include desktop in your analysis?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was anticipating doing everything on mobile for consistency because some metrics are only available on lighthouse dataset which is mobile.

@patrickhulce patrickhulce changed the title queries(third-parties): add top-100 domain queries Chapter 5: Add All Byte and Request Count Queries Aug 1, 2019
rviscomi
rviscomi requested changes Aug 2, 2019
View reviewed changes
sql/2019/05_Third_Parties/05_03.sql Show resolved Hide resolved
sql/2019/05_Third_Parties/05_01.sql Outdated Show resolved Hide resolved
sql/2019/05_Third_Parties/05_02.sql Outdated Show resolved Hide resolved
sql/2019/05_Third_Parties/05_04.sql Show resolved Hide resolved
sql/2019/05_Third_Parties/05_07.sql Show resolved Hide resolved
sql/2019/05_Third_Parties/05_09.sql Outdated Show resolved Hide resolved
sql/2019/05_Third_Parties/05_09.sql Outdated Show resolved Hide resolved
@rviscomi
Copy link
Member

rviscomi commented Aug 9, 2019

Is this ready for another review?

@patrickhulce
Copy link
Contributor Author

Oh sorry I missed your thumbs up! Let me apply the last bit then.

@patrickhulce
Copy link
Contributor Author

Oh sorry I missed your thumbs up!

Aside: is there any GH setting I don't know about that lets you get notifications about that? I imagine it could get annoying for certain types, but code review comments would be nice.

@patrickhulce
Copy link
Contributor Author

Yep I think it's ready @rviscomi!

rviscomi
rviscomi requested changes Aug 9, 2019
View reviewed changes
sql/2019/05_Third_Parties/05_01.sql Outdated Show resolved Hide resolved
sql/2019/05_Third_Parties/05_01.sql Outdated Show resolved Hide resolved
sql/2019/05_Third_Parties/05_01.sql Outdated Show resolved Hide resolved
sql/2019/05_Third_Parties/05_06.sql Outdated Show resolved Hide resolved
@rviscomi rviscomi merged commit 1893669 into master Aug 15, 2019
@rviscomi rviscomi deleted the 3p_top_domains branch June 18, 2020 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rviscomi rviscomi rviscomi approved these changes

Assignees
No one assigned
Labels
analysis Querying the dataset
Projects
None yet
Milestone
Content written
Development

Successfully merging this pull request may close these issues.
2 participants
@patrickhulce @rviscomi