-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query metrics: Chapter 9. Accessibility #90
Comments
@dougsillars you've checked off a few of the metrics but I don't see a PR for their respective queries. Do you have that ready for review? |
It lookeded like they all went into my chapter 4 PR at one point, because
you commented on them. If not, I'll try another PR
…On Sun, 8 Sep 2019, 06:52 Rick Viscomi, ***@***.***> wrote:
@dougsillars <https://github.com/dougsillars> you've checked off a few of
the metrics but I don't see a PR for their respective queries. Do you have
that ready for review?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#90?email_source=notifications&email_token=AALRWMHFIP356646BPCAY7LQISHKTA5CNFSM4IGH5HQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6FIOOA#issuecomment-529172280>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AALRWMC4M3GBMCG72ARUONTQISHKTANCNFSM4IGH5HQA>
.
|
@dougsillars ok thanks a new PR would be great |
They are in the chapter 4 PR. Do I remove them from that one, and then
create a new one?
…On Sun, 8 Sep 2019, 18:22 Rick Viscomi, ***@***.***> wrote:
@dougsillars <https://github.com/dougsillars> ok thanks a new PR would be
great
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#90?email_source=notifications&email_token=AALRWMAR5Y4Z4AXNW23Q2RLQIUYDZA5CNFSM4IGH5HQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6FU7SY#issuecomment-529223627>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AALRWMAKVYID5DCUJNYK2WLQIUYDZANCNFSM4IGH5HQA>
.
|
Yes please 😊 |
@rviscomi Want me to take care of the 9.23 and 9.25? After which we should be able to close out this issue |
Yes, that'd be great thanks! |
READ ME!
All of the metrics in the table below have been marked as
Able To Query
during the metrics triage. The analyst assigned to each metric is expected to write the corresponding query and submit a PR to have it reviewed and added to the repo.In order to stay on schedule and have the data ready for authors, please have all metrics reviewed and merged by August 5.
Assignments
id
attributes are not unique across the page.<th>
, role=”rowheader” and role=”columnheader” elements. [1]Checklist of metrics to be merged
<div role='main'>
, etc)? Thoughts?id
attributes are not unique across the page.<th>
, role=”rowheader” and role=”columnheader” elements. [1]The text was updated successfully, but these errors were encountered: