Skip to content

Commit

Permalink
Fixed typo in js featured snippet (#941)
Browse files Browse the repository at this point in the history
* fix: typo in js featured snippet

* fix(featured_chapter/js): explanation of 3P and 1P

* fix(blockquote):add line-height to make it easier to read
  • Loading branch information
kresnasatya authored Jun 30, 2020
1 parent f29046c commit b449299
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions src/static/css/2019.css
Original file line number Diff line number Diff line change
Expand Up @@ -724,6 +724,7 @@ blockquote {
font-style: italic;
font-size: 19px;
font-size: 1.1875rem;
line-height: 1.5em;
}

blockquote::before {
Expand Down
2 changes: 1 addition & 1 deletion src/templates/en/2019/featured_chapters.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{%- if featured_chapter == "javascript" %}
{%- set featured_chapter_name = "JavaScript" %}
{%- set featured_chapter_quote = "JavaScript is the most costly resource we send to browsers; having to be downloaded, parsed, compiled, and finally executed. Although browsers have significantly decreased the time it takes to parse and compile scripts, download and execution have become the most expensive stages when JavaScript is processed by a web page." %}
{%- set featured_chapter_stats = {"stat1":"89%","label1":"Sites with more 3P code that 1P","stat2":"83%","label2":"Sites that use jQuery","stat3":"4.6%","label3":"Home pages using React"} %}
{%- set featured_chapter_stats = {"stat1":"89%","label1":"Sites with more third-party code than first-party","stat2":"83%","label2":"Sites that use jQuery","stat3":"4.6%","label3":"Home pages using React"} %}
{%- elif featured_chapter == "css" %}
{%- set featured_chapter_name = "CSS" %}
{%- set featured_chapter_quote = "Cascading Style Sheets (CSS) are used to paint, format, and layout web pages. Their capabilities span concepts as simple as text color to 3D perspective. It also has hooks to empower developers to handle varying screen sizes, viewing contexts, and printing. CSS helps developers wrangle content and ensure it's adapting properly to the user." %}
Expand Down
2 changes: 1 addition & 1 deletion src/templates/es/2019/featured_chapters.html
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
{%- if featured_chapter == "javascript" %}
{%- set featured_chapter_name = "JavaScript" %}
{%- set featured_chapter_quote = "JavaScript is the most costly resource we send to browsers; having to be downloaded, parsed, compiled, and finally executed. Although browsers have significantly decreased the time it takes to parse and compile scripts, download and execution have become the most expensive stages when JavaScript is processed by a web page." %}
{%- set featured_chapter_stats = {"stat1":"89%","label1":"Sites with more 3P code that 1P","stat2":"83%","label2":"Sites that use jQuery","stat3":"4.6%","label3":"Home pages using React"} %}
{%- set featured_chapter_stats = {"stat1":"89%","label1":"Sites with more third-party code than first-party","stat2":"83%","label2":"Sites that use jQuery","stat3":"4.6%","label3":"Home pages using React"} %}
{%- elif featured_chapter == "css" %}
{%- set featured_chapter_name = "CSS" %}
{%- set featured_chapter_quote = "Cascading Style Sheets (CSS) are used to paint, format, and layout web pages. Their capabilities span concepts as simple as text color to 3D perspective. It also has hooks to empower developers to handle varying screen sizes, viewing contexts, and printing. CSS helps developers wrangle content and ensure it's adapting properly to the user." %}
Expand Down
2 changes: 1 addition & 1 deletion src/templates/fr/2019/featured_chapters.html
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
{%- if featured_chapter == "javascript" %}
{%- set featured_chapter_name = "JavaScript" %}
{%- set featured_chapter_quote = "JavaScript is the most costly resource we send to browsers; having to be downloaded, parsed, compiled, and finally executed. Although browsers have significantly decreased the time it takes to parse and compile scripts, download and execution have become the most expensive stages when JavaScript is processed by a web page." %}
{%- set featured_chapter_stats = {"stat1":"89%","label1":"Sites with more 3P code that 1P","stat2":"83%","label2":"Sites that use jQuery","stat3":"4.6%","label3":"Home pages using React"} %}
{%- set featured_chapter_stats = {"stat1":"89%","label1":"Sites with more third-party code than first-party","stat2":"83%","label2":"Sites that use jQuery","stat3":"4.6%","label3":"Home pages using React"} %}
{%- elif featured_chapter == "css" %}
{%- set featured_chapter_name = "CSS" %}
{%- set featured_chapter_quote = "Cascading Style Sheets (CSS) are used to paint, format, and layout web pages. Their capabilities span concepts as simple as text color to 3D perspective. It also has hooks to empower developers to handle varying screen sizes, viewing contexts, and printing. CSS helps developers wrangle content and ensure it's adapting properly to the user." %}
Expand Down

0 comments on commit b449299

Please sign in to comment.