Add module-info #28
Open
Add module-info #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gk-brown
reviewed
Dec 18, 2024
| requires transitive java.desktop; | ||
|
|
||
| exports org.httprpc.sierra; | ||
|
|
There was a problem hiding this comment.
Minor, but this newline is not needed.
gk-brown
reviewed
Dec 18, 2024
| @@ -0,0 +1,6 @@ | |||
| module sierra { | |||
There was a problem hiding this comment.
Based on this SO discussion, it seems that the module name should be org.httprpc.sierra:
https://stackoverflow.com/questions/43192741/how-should-i-name-my-java-9-module
gk-brown
reviewed
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
module-info.java.This packages Sierra as a Java 9 module, allowing it to be used in modular projects. Also, apps built with Sierra can be easily included in Jlink deployments, a benefit when running Swing-based apps on the desktop.