Handle invalid references when browsing #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgoll
force-pushed
the
browse-references
branch
from
569b6ea to
78154fc
Compare
uklotzde
approved these changes
Mar 18, 2024
uklotzde
pushed a commit
that referenced
this pull request
Mar 19, 2024
## Description This removes the unnecessary `Option` from the return type of `AsyncClient::call_method()`. It was used to indicate that the method returned an unset (invalid) array of output arguments but that should not happen within the specification.[^1] [^1]: In any case, it would be unclear what the meaning behind this was when the call itself was successful. We treat this as an empty list of output arguments, similar to what we did for `AsyncClient::browse()` in #77.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some PLCs return an invalid (unset) array of references when browsing a node with no children. While not exactly specified in the OPC UA standard, the sensible thing to do here is to threat it the same as an empty array and not as an error.