Add ability to fetch endpoints from server #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sgoll
force-pushed
the
fetch-certificate
branch
from
ad5cb75 to
d348ddd
Compare
sgoll
force-pushed
the
fetch-certificate
branch
from
9382029 to
71370a0
Compare
sgoll
changed the title
sgoll
force-pushed
the
fetch-certificate
branch
2 times, most recently
from
b2aada6 to
eff61b9
Compare
uklotzde
reviewed
Dec 9, 2024
uklotzde
reviewed
Dec 9, 2024
| // Apply heuristic to get certificates from both DER and PEM format. Try PEM first because | ||
| // the implementation first extracts DER data from PEM and can tell us whether this failed | ||
| // (or the certificate itself was invalid). | ||
| X509Certificate::from_pem(self.as_bytes()).or_else(|err| match err { |
There was a problem hiding this comment.
Even though the new code does not really improve readability it emphasizes the intended fallback behavior.
uklotzde
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds
ClientBuilder::get_endpoints()to connect to a remote OPC UA server and fetch its endpoints.