Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

支持下载光影等 #2794

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

支持下载光影等 #2794

wants to merge 3 commits into from

Conversation

burningtnt
Copy link
Member

@burningtnt burningtnt commented Feb 13, 2024 •
edited
Loading

  • 简化重复的 LocalizedRemoteModRepository 代码
  • 支持下载光影
    image
  • 支持下载数据包

@burningtnt
Copy link
Member Author

burningtnt commented Feb 13, 2024 •
edited
Loading

image
我注意到 org.jackhuang.hmcl.ui.download.DownloadPage::new 有这样一段代码，但这个 Tab 从未被渲染，应当移除吗？

@burningtnt burningtnt requested a review from Glavo February 13, 2024 06:23
@burningtnt
Copy link
Member Author

customizationTab 在 HMCL 的 I18N 里有遗留，中文简体为“光影和游戏定制”

@burningtnt
Copy link
Member Author

image
绷不住了，这段代码在最初进 HMCL 主线的时候，就已经被注释了

@burningtnt burningtnt closed this Feb 13, 2024
@burningtnt burningtnt reopened this Feb 13, 2024
@zkitefly
Copy link
Member

image

我记得 CurseForge 是支持光影包的啊

@ShulkerSakura
Copy link
Contributor

不推荐推进该功能，光影和资源包感觉不适合接平台，很多光影也不登陆这种平台作为自己的发布渠道，而且Optifine或者Iris乃至是Optifine的版本都会影响到着色器是否可以正常渲染，资源包是否功能正常，该功能的推荐会进一步削减玩家自己寻找资源的能力，存在会使不少未使用Modrinth/Curseforge发行的宝贵资源被埋没或被忽略的可能性。

@ShulkerSakura
Copy link
Contributor

最主要的是，绝大部分光影和资源包并不受Minecraft客户端版本限制，按照mc版本分类十分不妥

@burningtnt burningtnt mentioned this pull request Feb 13, 2024
Merged
@burningtnt
Copy link
Member Author

burningtnt commented Feb 19, 2024 •
edited
Loading

暂时先观察一下支持下载光影和材质包的必要性

@burningtnt burningtnt closed this Feb 19, 2024
@burningtnt burningtnt deleted the feature/optimize-download branch February 19, 2024 11:43
@burningtnt burningtnt restored the feature/optimize-download branch May 8, 2024 11:32
@burningtnt
Copy link
Member Author

burningtnt commented May 8, 2024 •
edited
Loading

目前根据 HMCL 用户群的观察，大部分用户依然依赖启动器选择光影。经深入交流，其原因集中在

  • 无法看懂 CurseForge / Modrinth 的英文
  • 不知道有哪里可以下载光影

或许引入该功能是有必要的。

或许可以接入 https://docs.minegraph.cn/home.html？

无论如何，都需要进一步的长时间观察

@burningtnt burningtnt reopened this May 8, 2024
@burningtnt burningtnt mentioned this pull request Jul 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Glavo Glavo Awaiting requested review from Glavo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@burningtnt @zkitefly @ShulkerSakura