-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to include Google analytics scripts in IG pages #256
Comments
if we do this I would just make sure it is conditional to the existence of the google analytics ID, to make sure templates or IGs that don't provide the ID would not have broken javascript |
@costateixeira, of course. That would also give people who don't want google tracking to avoid it. |
This is a followup to HL7/fhir-ig-publisher#383 which was interpreted to only request a way to specify an ID, not to actually specify and use it. |
This is a template thing, nothing to do with the publisher |
Transferring to https://github.com/HL7/ig-template-base, where this belongs |
I believe this works, in part, by putting a cookie on the client machine to track which pages that particular client navigates to. I think the google script includes an ability to integrate with a (perhaps third party) consent banner, so this shouldn't be a problem for people who need to worry about cookie consent. Use of the google tag is also an opt-in capability on the IG author's part, so this really shouldn't be an issue for authors who are concerned. However, @lmckenzi, you may want to confirm behaviour is acceptable to HL7 before making it the default for HL7 IGs. |
We may also want to make it easy to replace the entire script with something more complex in a derived template. (I notice my website uses a modified script to filter out page views by the site admin, etc.). |
Use of cookies is a decision by the author that impacts users. Do we need
the common considerations about cookies, gdpr, consent, etc? I do not know
what these cookies store from the user and i don't think we should ignore
that. And if it requires a consent popup, does google analytics provide
that?
…On Sat, 9 Nov 2024, 19:07 Elliot Silver, ***@***.***> wrote:
I believe this works, in part, by putting a cookie on the client machine
to track which pages that particular client navigates to. I *think* the
google script includes an ability to integrate with a (perhaps third party)
consent banner, so this shouldn't be a problem for people who need to worry
about cookie consent. Use of the google tag is also an opt-in capability on
the IG author's part, so this really shouldn't be an issue for authors who
are concerned. However, @lmckenzi <https://github.com/lmckenzi>, you may
want to confirm behaviour is acceptable to HL7 before making it the default
for HL7 IGs.
—
Reply to this email directly, view it on GitHub
<#256 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD3HUUDC7RG7O4TB5FWNUG3Z7ZFP5AVCNFSM6AAAAABQ67EDIWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRWGM2TSNRXHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
My understanding is that consent management is always needed if you track IPs. I am sure Google has tools to help, but we should just make sure that by default, the base template doesn't introduce risks |
Also clean up the existing comments so they don't mislead people about how this should be done going forward. |
To track page views, add following script just after
</head>
on every page of the IG.G-ABCDE12345
should be replaced by a variable that can be specified in features.yml (?)The text was updated successfully, but these errors were encountered: